Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fallback to offline access token login #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iamkirkbater
Copy link
Contributor

Adds a fallback for prod access with offline access tokens but adds a warning, and proceeds to use device code login for OCM when in the staging or integration environments.

Per some feedback received in slack this should allow both access mechanisms to give SREs more time to switch without breaking current prod workflows.

Adds a fallback for prod access with offline access tokens but adds a
warning, and proceeds to use device code login for OCM when in the
staging or integration environments.
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@iamkirkbater
Copy link
Contributor Author

I walked through this with an expired OCM token and it worked fine.

But then I logged into OCM outside of the container and attempted to run this again and all logins worked fine.

Then I ran ocm logout outside of the container and attempted to run the container again, and now all environments fail to work.

This needs more work and testing before merging.

@clcollins
Copy link
Member

/hold

Based on @iamkirkbater's last comment

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@rendhalver
Copy link
Contributor

This is kind of a stopgap feature.
Given that offline tokens will be disabled in Prod soon and this won't be needed after then should we switch focus to getting the new login scheme working nicer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants