-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vsphere nodeip-configuration.service: run node-ip binary from container #1829
vsphere nodeip-configuration.service: run node-ip binary from container #1829
Conversation
/test e2e-vsphere |
openshift/release#9702 would add IPI tests. UPI flow is not affected with this change |
/test e2e-vsphere-upi |
Let's retry IPI - bootstrap didn't complete |
/test e2e-vsphere |
cri-o is unhappy, that is the wrong ip for the node
|
/test e2e-vsphere |
Ah, the service runs right after the firstboot, records that IP - and then machine-config-daemon-host.service pivots to new machine-os-content, reboots - and VM gets another IP |
/test e2e-vsphere |
26dc1b9
to
38b2340
Compare
/test e2e-vsphere |
38b2340
to
85441f3
Compare
/test e2e-vsphere |
85441f3
to
1525b94
Compare
/test e2e-vsphere |
1525b94
to
ce18b1f
Compare
/test e2e-vsphere |
Use containerized golang binary instead python script. It also restarts systemd daemon to have crio settings applied to the loaded unit
ce18b1f
to
16be8fc
Compare
/test e2e-vsphere |
Cleaned up the commits and added |
This ensures base OS would not require python on the host
/test e2e-vsphere |
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/approve But I would really like to see us rethink this stuff at some point after 4.6 because we have much more powerful abilities since openshift/enhancements#291 particularly for VSphere to control exactly what the node is doing from the first boot. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jcpowermac, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- What I did
Replaced python
nodeip-finder
script with a baremetal's version running in container. This is required on FCOS, which doesn't have python interpreter. Also, this would deduplicate fixes for the same functionality- How to verify it
vSphere IPI install should pass
- Description for the changelog
Container is used to determine node IP for vSphere
/cc @jcpowermac @patrickdillon