Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1975527: upi/vsphere: Use Afterburn guestinfo for static IP and hostname config #3533

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Bug 1975527: upi/vsphere: Use Afterburn guestinfo for static IP and hostname config #3533

merged 2 commits into from
Feb 17, 2021

Conversation

LorbusChris
Copy link
Member

/test vsphere-upi

@openshift-ci-robot
Copy link
Contributor

@LorbusChris: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-proxy
  • /test e2e-aws-rhel8
  • /test e2e-aws-scaleup-rhel7
  • /test e2e-aws-shared-vpc
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi
  • /test e2e-azure
  • /test e2e-azure-shared-vpc
  • /test e2e-azure-upi
  • /test e2e-gcp
  • /test e2e-gcp-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi
  • /test e2e-libvirt
  • /test e2e-metal
  • /test e2e-metal-ipi
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-openstack-upi
  • /test e2e-ovirt
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test shellcheck
  • /test tf-fmt
  • /test tf-lint
  • /test unit
  • /test verify-vendor
  • /test yaml-lint

Use /test all to run all jobs.

In response to this:

/test vsphere-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

It seems the interface isn't coming up. I suspect NM's keyfile plugin is not enabled on RHCOS. Investigating.

@dustymabe
Copy link
Member

It seems the interface isn't coming up. I suspect NM's keyfile plugin is not enabled on RHCOS. Investigating.

Try naming the file "/etc/NetworkManager/system-connections/ens192.nmconnection". There are quite a few examples of key files in the test I've been running manually (see coreos/fedora-coreos-config#369)

@LorbusChris LorbusChris changed the title upi/vsphere: Use NM keyfile for static IP instead of ifcfg WIP: upi/vsphere: Use NM keyfile for static IP instead of ifcfg May 4, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2020
@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

2 similar comments
@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

@dustymabe @jcpowermac any ideas why this isn't working? Are the boot images maybe not supporting keyfiles, yet?

@LorbusChris
Copy link
Member Author

I've rolled back the wip commits. Name is ens192 again, although that didn't work earlier either.

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

/retest

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

1 similar comment
@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@cgwalters
Copy link
Member

Keep in mind this is only going to affect networking in the real root, not at Ignition time.

For that we need the installer to make use of openshift/enhancements#291 specifically coreos/afterburn#404

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

4 similar comments
@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

LorbusChris commented Jan 15, 2021 •
edited
Loading

vsphere UPI failures look like flakes to me

/test e2e-vsphere-upi

@LorbusChris
Copy link
Member Author

/test e2e-aws-fips
/test e2e-aws

@LorbusChris
Copy link
Member Author

@jcpowermac @staebler any chance you can take a look at this again soon?

@jcpowermac
Copy link
Contributor

@LorbusChris upi passed
I think this LGTM

@staebler
Copy link
Contributor

My naive reading of this comment from @cgwalters is that the network settings will not be available at ignition time, which seems to be the same as what we had before with configuring the settings via ignition configs.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2021 •
edited
Loading

@LorbusChris: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 9f8698d link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 816fd3f into openshift:master Feb 17, 2021
@LorbusChris
Copy link
Member Author

/cherry-pick fcos

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 19, 2021
Merged
@openshift-cherrypick-robot
Copy link

@LorbusChris: new pull request created: #4673

In response to this:

/cherry-pick fcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3
Copy link
Contributor

Cherry-picking this to 4.7 due to issues found in vSphere UPI CI jobs.

/cherry-pick release-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 23, 2021
Merged
@openshift-cherrypick-robot
Copy link

@rvanderp3: new pull request created: #5025

In response to this:

Cherry-picking this to 4.7 due to issues found in vSphere UPI CI jobs.

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3
Copy link
Contributor

/retitle Bug 1975527: upi/vsphere: Use Afterburn guestinfo for static IP and hostname config

@openshift-ci openshift-ci bot changed the title upi/vsphere: Use Afterburn guestinfo for static IP and hostname config Bug 1975527: upi/vsphere: Use Afterburn guestinfo for static IP and hostname config Jun 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

@LorbusChris: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1975527 has not been moved to the MODIFIED state.

In response to this:

Bug 1975527: upi/vsphere: Use Afterburn guestinfo for static IP and hostname config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jun 24, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

@sdodson: All pull requests linked via external trackers have merged:

Bugzilla bug 1975527 has been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@jcpowermac jcpowermac jcpowermac left review comments

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@staebler staebler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.