Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-2196: User-facing audit-log configuration #1551

Merged
merged 1 commit into from
Feb 29, 2024
Merged

USHIFT-2196: User-facing audit-log configuration #1551

merged 1 commit into from
Feb 29, 2024

Conversation

copejon
Copy link
Contributor

@copejon copejon commented Jan 26, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2024 •
edited by openshift-ci bot
Loading

@copejon: This pull request references USHIFT-2196 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@copejon copejon force-pushed the ushift-2196-audit-log-configuration branch 3 times, most recently from 7bf59d8 to 215510d Compare February 7, 2024 23:11
@dhellmann
Copy link
Contributor

#1555 is changing the enhancement template in a way that will cause the header check in the linter job to fail for existing PRs. If this PR is merged within the development period for 4.16 you may override the linter if the only failures are caused by issues with the headers (please make sure the markdown formatting is correct). If this PR is not merged before 4.16 development closes, please update the enhancement to conform to the new template.

@copejon copejon force-pushed the ushift-2196-audit-log-configuration branch from effb7ea to 2787183 Compare February 14, 2024 18:06
pmtk
pmtk reviewed Feb 16, 2024
View reviewed changes
Copy link
Member

@pmtk pmtk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor things, otherwise looks good to me

@pmtk
Copy link
Member

pmtk commented Feb 19, 2024

LGTM

@copejon copejon force-pushed the ushift-2196-audit-log-configuration branch 2 times, most recently from 4b2a3b1 to 901f33f Compare February 21, 2024 19:53
@jcantrill
Copy link
Contributor

/unassign

@pmtk
Copy link
Member

pmtk commented Feb 28, 2024

LGTM

@copejon copejon force-pushed the ushift-2196-audit-log-configuration branch from c35e7b2 to 4d74f4c Compare February 28, 2024 19:42
@copejon
microshift: expose audit log config values via user config file
7bd3fe9 
Signed-off-by: Jon Cope <jcope@redhat.com>
@copejon
Copy link
Contributor Author

copejon commented Feb 28, 2024

/test markdownlint

@copejon copejon force-pushed the ushift-2196-audit-log-configuration branch from 4d74f4c to 7bd3fe9 Compare February 28, 2024 19:58
@copejon
Copy link
Contributor Author

copejon commented Feb 28, 2024

/test markdownlint

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@copejon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann
Copy link
Contributor

Consensus discussed in https://redhat-internal.slack.com/archives/C03CJTNLKAT/p1709072271990709

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 910f223 into openshift:master Feb 29, 2024
2 checks passed
@copejon copejon deleted the ushift-2196-audit-log-configuration branch February 29, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann left review comments

@pmtk pmtk pmtk left review comments

@jerpeter1 jerpeter1 jerpeter1 left review comments

@ggiguash ggiguash ggiguash left review comments

@jcantrill jcantrill Awaiting requested review from jcantrill

@travier travier Awaiting requested review from travier

Assignees

@dhellmann dhellmann

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@copejon @openshift-ci-robot @dhellmann @pmtk @jcantrill @jerpeter1 @ggiguash