Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics collection profiles #1298

Closed
wants to merge 26 commits into from
Closed

Metrics collection profiles #1298

wants to merge 26 commits into from

Conversation

JoaoBraveCoding
Copy link
Contributor

@JoaoBraveCoding JoaoBraveCoding commented Dec 7, 2022 •
edited
Loading

This PR proposes the addition of the metrics collection profiles feature for the cluster-monitoring-operator

Issue https://issues.redhat.com/browse/MON-3043

@JoaoBraveCoding
Copy link
Contributor Author

JoaoBraveCoding commented Dec 7, 2022 •
edited
Loading

/assign @simonpasquier @jan--f

Some sections still need to be finished and I still want to polish the text in some parts but consider it a v1 ;)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2022
@JoaoBraveCoding JoaoBraveCoding changed the title Scrape Profiles WIP: Scrape Profiles Dec 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

jan--f
jan--f reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I left a few comments to start us off.

enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
simonpasquier
simonpasquier reviewed Dec 16, 2022
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice start!

enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
jan--f
jan--f reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments, but I think this looks pretty good. I think the draft status can be removed soon so we can gather feedback from others.

@JoaoBraveCoding
Added analysis to motivation, added more alternatives, added concrete
061c590 
ServiceMonitor examples

Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
simonpasquier
simonpasquier reviewed Jan 17, 2023
View reviewed changes
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
enhancements/monitoring/scrape-profiles.md Outdated Show resolved Hide resolved
JoaoBraveCoding and others added 3 commits January 20, 2023 12:58
@JoaoBraveCoding @simonpasquier
Apply Simon suggestions from code review
7d210b7 
Co-authored-by: Simon Pasquier <spasquie@redhat.com>
@JoaoBraveCoding
Addressed Simon review
995f2de
@JoaoBraveCoding
Adds reference to Hypershift implementation of scrape profiles
719b231 
Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2023
@JoaoBraveCoding
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 13, 2023
@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 11, 2023
@openshift-bot
Copy link

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Rotten proposals close after an additional 7d of inactivity.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

rexagod added a commit to rexagod/origin that referenced this pull request Jun 6, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
1cb24f3 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 10, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
acec341 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 10, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
36a2ac4 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 11, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
17fe486 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 11, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
55f053a 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 11, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
ed73c18 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 12, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
24f7bb0 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 12, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
8b31d96 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 12, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
ea1d90d 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 12, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
2f0c96b 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 12, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
1a79274 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 15, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
e83359e 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 15, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
28e1bd1 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 15, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
3ae0a7e 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 16, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
17e960b 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 16, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
295bd30 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 17, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
1d1f42d 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 17, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
f22b1c0 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 17, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
8c33801 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 17, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
77ea289 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 18, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
62a5604 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 18, 2024
@rexagod
MON-3775: add tests for CMO collection profiles
fb2f115 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jun 18, 2024
@rexagod
MON-3775: add tests for the MetricsCollectionProfiles feature-gate
172346d 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod rexagod mentioned this pull request Jun 18, 2024
Open
rexagod added a commit to rexagod/origin that referenced this pull request Jul 23, 2024
@rexagod
MON-3775: add tests for the MetricsCollectionProfiles feature-gate
53ba103 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jul 29, 2024
@rexagod
MON-3775: add tests for the MetricsCollectionProfiles feature-gate
7dc7eb1 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Jul 30, 2024
@rexagod
MON-3775: add tests for the MetricsCollectionProfiles feature-gate
51d00f0 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Sep 9, 2024
@rexagod
MON-3775: add tests for the MetricsCollectionProfiles feature-gate
50fdd78 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Sep 11, 2024
@rexagod
MON-3775: add tests for the MetricsCollectionProfiles feature-gate
8d8b965 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/origin that referenced this pull request Sep 11, 2024
@rexagod
MON-3775: add tests for the MetricsCollectionProfiles feature-gate
da1d01a 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f jan--f left review comments

@simonpasquier simonpasquier simonpasquier left review comments

@bparees bparees bparees left review comments

@dgrisonnet dgrisonnet dgrisonnet left review comments

@juzhao juzhao juzhao left review comments

@rexagod rexagod rexagod left review comments

@dmage dmage Awaiting requested review from dmage

Assignees

@jan--f jan--f

@simonpasquier simonpasquier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@JoaoBraveCoding @openshift-bot @dhellmann @jan--f @rexagod @dgrisonnet @simonpasquier @bparees @juzhao