Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-2222: Enable validating webhook for AlertmanagerConfig custom resources #1567

Merged
merged 5 commits into from
Mar 17, 2022
Merged

MON-2222: Enable validating webhook for AlertmanagerConfig custom resources #1567

merged 5 commits into from
Mar 17, 2022

Conversation

philipgough
Copy link
Contributor

@philipgough philipgough commented Feb 24, 2022 •
edited
Loading

Fixes https://issues.redhat.com/browse/MON-2222

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2022
@philipgough philipgough changed the title WIP Enable validating webhook for AlertmanagerConfig customer resources Feb 28, 2022
@philipgough
Copy link
Contributor Author

/skip

@philipgough
Copy link
Contributor Author

/retest-required

1 similar comment
@philipgough
Copy link
Contributor Author

/retest-required

@philipgough
Copy link
Contributor Author

/test e2e-agnostic-upgrade

2 similar comments
@philipgough
Copy link
Contributor Author

/test e2e-agnostic-upgrade

@philipgough
Copy link
Contributor Author

/test e2e-agnostic-upgrade

@prashbnair
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PhilipGough, prashbnair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PhilipGough,prashbnair]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@philipgough
Copy link
Contributor Author

/test e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2022 •
edited
Loading

@philipgough: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions b894593 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@philipgough
Copy link
Contributor Author

cc @juzhao for qe input

@philipgough
Copy link
Contributor Author

/label docs-approved

Have chatted to @bburt-rh about this one and the overarching epic

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Mar 10, 2022
@philipgough philipgough changed the title Enable validating webhook for AlertmanagerConfig customer resources Enable validating webhook for AlertmanagerConfig custom resources Mar 10, 2022
@philipgough
Copy link
Contributor Author

cc @sferich888 for px-approval

@jan--f
Copy link
Contributor

jan--f commented Mar 15, 2022 •
edited by openshift-ci bot
Loading

/retitle MON-2222: Enable validating webhook for AlertmanagerConfig custom resources

@openshift-ci openshift-ci bot changed the title Enable validating webhook for AlertmanagerConfig custom resources MON-2222: Enable validating webhook for AlertmanagerConfig custom resources Mar 15, 2022
@juzhao
Copy link

juzhao commented Mar 16, 2022

the alertmanagerconfig validation is enabled on the cluster, only one low severity bug: https://bugzilla.redhat.com/show_bug.cgi?id=2064705
since it is a low severity error, we can merge code first
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 16, 2022
@Senthamilarasu-STA
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Mar 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit a062251 into openshift:master Mar 17, 2022
@philipgough philipgough deleted the amc-validating-webhook branch March 25, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpetkovski fpetkovski Awaiting requested review from fpetkovski

@prashbnair prashbnair Awaiting requested review from prashbnair

Assignees

@prashbnair prashbnair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@philipgough @prashbnair @openshift-bot @jan--f @juzhao @Senthamilarasu-STA @openshift-merge-robot