Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-2015: Rebase to upstream v2.0.7 for OCP 4.18 #86

Merged
merged 65 commits into from
Sep 30, 2024

Conversation

seanzatzdev-amazon and others added 30 commits April 15, 2024 14:45
Rust and Cargo are required to build efs-utils v2.0.0.

I also a TODO to one of our integration tests - now that non-tls mounts
are also re-directed to localhost (efs-utils v2), we need a new method
of determining whether 'encryptInTransit' is working as expected.

(cherry picked from commit f503354)
(cherry picked from commit 5a73a76)
…2.0.1

Post-release PR for v2.0.1 and also changed the Default image from do…
Update CHANGELOG to include 2.x for newer versions.
Update the Helm configuration to use Public ECR image  default rather…
(cherry picked from commit 8bf61b7)
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 5, 2024

@dfajmon: This pull request references STOR-2015 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Issue link:
https://issues.redhat.com/browse/STOR-2015

Diff to upstream v2.0.5:
kubernetes-sigs/aws-efs-csi-driver@v2.0.5...dfajmon:rebase-v2.0.7

Changes between v2.0.5 (OCP 4.17) and v2.0.7 (OCP 4.18):

Full changelogs:
https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/CHANGELOG-2.x.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Additional changes:

- remove .github files
- do not overwrite GOARCH in makefile
- go mod tidy && go mod vendor
@jsafrane
Copy link

/lgtm
/approve
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Sep 16, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@Phaow
Copy link

Phaow commented Sep 30, 2024

Pre merge test with manually build the driver/operator/bunddle/index images passed.
The notable changes have no added new features regression test passed.

$ oc get csv
NAME                                  DISPLAY                       VERSION   REPLACES   PHASE
aws-efs-csi-driver-operator.v4.18.0   AWS EFS CSI Driver Operator   4.18.0               Succeeded

$ oc rsh -c csi-driver aws-efs-csi-driver-controller-68b86d5dbf-74wwl
sh-5.1# /usr/bin/aws-efs-csi-driver -version
{
  "driverVersion": "v2.0.7",
  "gitCommit": "60e489f19845a455579f7bbf9becb4b8b74c2f64",
  "buildDate": "2024-09-29T02:37:01Z",
  "efsClientSource": "k8s",
  "goVersion": "go1.22.5 (Red Hat 1.22.5-1.el9) X:strictfipsruntime",
  "compiler": "gc",
  "platform": "linux/amd64"
}

# Regression test result
55 pass, 15 skip (28m43s)

@Phaow
Copy link

Phaow commented Sep 30, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 30, 2024

@dfajmon: This pull request references STOR-2015 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Issue link:
https://issues.redhat.com/browse/STOR-2015

Diff to upstream v2.0.5:
kubernetes-sigs/aws-efs-csi-driver@v2.0.5...dfajmon:rebase-v2.0.7

Changes between v2.0.5 (OCP 4.17) and v2.0.7 (OCP 4.18):

Full changelogs:
https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/CHANGELOG-2.x.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Sep 30, 2024

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit caf6889 into openshift:master Sep 30, 2024
7 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-efs-csi-driver
This PR has been included in build ose-aws-efs-csi-driver-container-v4.18.0-202409300340.p0.gcaf6889.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.