Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working through examples to update commands #41

Merged
merged 5 commits into from
Oct 27, 2020
Merged

Working through examples to update commands #41

merged 5 commits into from
Oct 27, 2020

Conversation

abrennan89
Copy link
Collaborator

No description provided.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abrennan89
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lance
lance reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor comments. Sorry that things keep shifting. All should be settled in the next few days.

modules/ROOT/pages/quickstart-functions.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/quickstart-functions.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/quickstart-functions.adoc Outdated Show resolved Hide resolved
@abrennan89 abrennan89 merged commit b74314e into openshift-knative:master Oct 27, 2020
@abrennan89 abrennan89 changed the title [WIP] Working through examples to update commands Working through examples to update commands Oct 27, 2020
@abrennan89 abrennan89 deleted the quickstartupdate branch October 28, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abrennan89 @openshift-ci-robot @lance