Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.11] Expanding Authentication with SecurityRequest Abstraction (#3430) #3488

Conversation

peternied
Copy link
Member

Description

Backport of f435c05 from #3430

Introduced a new abstraction, SecurityRequest & SecurityRequestChannel, to streamline and secure the authentication process in the OpenSearch Security plugin. By isolating the essential request components needed for authentication, we minimize potential risks associated with previous designs and provide a more maintainable architecture.

Signed-off-by: Peter Nied petern@amazon.com
(cherry picked from commit f435c05)

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-trigger-bot bot and others added 3 commits October 6, 2023 17:32
…roject#3460)

Backport 8752074 from opensearch-project#3454.

Signed-off-by: David Osorno <daosgu27@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…tion (opensearch-project#3430)

Introduced a new abstraction, SecurityRequest & SecurityRequestChannel,
to streamline and secure the authentication process in the OpenSearch
Security plugin. By isolating the essential request components needed
for authentication, we minimize potential risks associated with previous
designs and provide a more maintainable architecture.

Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit f435c05)
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #3488 (6a669b6) into 2.11 (8b6f2d7) will increase coverage by 0.03%.
The diff coverage is 64.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##               2.11    #3488      +/-   ##
============================================
+ Coverage     64.64%   64.67%   +0.03%     
- Complexity     3538     3565      +27     
============================================
  Files           261      267       +6     
  Lines         19808    19893      +85     
  Branches       3324     3329       +5     
============================================
+ Hits          12804    12866      +62     
- Misses         5370     5387      +17     
- Partials       1634     1640       +6     
Files Coverage Δ
...ava/org/opensearch/security/auditlog/AuditLog.java 100.00% <ø> (ø)
...security/auditlog/AuditLogSslExceptionHandler.java 57.14% <ø> (ø)
...org/opensearch/security/auditlog/NullAuditLog.java 0.00% <ø> (ø)
...earch/security/auditlog/impl/AbstractAuditLog.java 76.59% <ø> (ø)
...pensearch/security/auditlog/impl/AuditLogImpl.java 89.28% <ø> (ø)
...ava/org/opensearch/security/auth/UserInjector.java 90.66% <ø> (ø)
...arch/security/dlic/rest/api/AbstractApiAction.java 88.61% <100.00%> (ø)
...earch/security/dlic/rest/api/NodesDnApiAction.java 89.74% <ø> (ø)
...rity/dlic/rest/api/RestApiPrivilegesEvaluator.java 69.23% <100.00%> (+0.15%) ⬆️
...curity/dlic/rest/validation/EndpointValidator.java 94.20% <ø> (ø)
... and 30 more

... and 1 file with indirect coverage changes

@DarshitChanpura
Copy link
Member

@peternied Can you check the DCO changes. Seems like it is coming from a different PR that will be fixed by: #3480

@peternied
Copy link
Member Author

Can you check the DCO changes. Seems like it is coming from a different PR that will be fixed by: #3480

Sometimes on merges DCO can get mixed up. Maintainers such as yourself can go into the check and there is a button to override the failure for circumstances such as this where the tool is being too sensitive and there is the correct sign off on the commit.

@DarshitChanpura DarshitChanpura merged commit ef1d27c into opensearch-project:2.11 Oct 6, 2023
56 checks passed
@peternied peternied deleted the backport/backport-3430-to-2.11 branch November 9, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants