Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back the renaming of jar file and update release notes 1.13 #1031

Merged

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Feb 11, 2021

opendistro-for-elasticsearch/security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Maintenance

  2. Github Issue # or road-map entry, if available:

  3. Description of changes:

  4. Revert back the renaming of jar file.

  5. Update release notes 1.13 to keep it up-to-date.

  6. Why these changes are required?

  7. Revert back the renaming of jar file.

  8. Update release notes 1.13 to keep it up-to-date.

  9. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
    No changes in behavior.

  10. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
    UT

  11. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  12. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@cliu123 cliu123 requested a review from a team as a code owner February 11, 2021 00:33
@cliu123 cliu123 force-pushed the Revert_the_renaming_of_jar_file branch from 9096dc6 to bbf40ce Compare February 11, 2021 00:35
@vrozov vrozov added the maintenance Project maintenance label Feb 11, 2021
vrozov
vrozov previously approved these changes Feb 11, 2021
@cliu123 cliu123 force-pushed the Revert_the_renaming_of_jar_file branch from 8addf56 to 2b60162 Compare February 11, 2021 01:42
@cliu123 cliu123 requested review from a team and sujithvm February 11, 2021 01:51
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1031 (d5bccf3) into main (8d8fec4) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1031      +/-   ##
============================================
+ Coverage     64.47%   64.55%   +0.08%     
  Complexity     3167     3167              
============================================
  Files           244      244              
  Lines         17034    17034              
  Branches       3022     3022              
============================================
+ Hits          10982    10996      +14     
+ Misses         4517     4503      -14     
  Partials       1535     1535              
Impacted Files Coverage Δ Complexity Δ
...security/configuration/DlsFlsFilterLeafReader.java 59.76% <0.00%> (-0.71%) 64.00% <0.00%> (ø%)
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 58.01% <0.00%> (+0.76%) 24.00% <0.00%> (+1.00%)
...ecurity/configuration/ConfigurationRepository.java 73.77% <0.00%> (+4.91%) 21.00% <0.00%> (ø%)
...relasticsearch/security/rest/TenantInfoAction.java 88.05% <0.00%> (+10.44%) 15.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d8fec4...2b60162. Read the comment docs.

@cliu123 cliu123 requested a review from a team February 11, 2021 02:53
@cliu123 cliu123 merged commit 9587d61 into opensearch-project:main Feb 11, 2021
cliu123 referenced this pull request in cliu123/ODFE-Security Mar 2, 2021
@cliu123 cliu123 deleted the Revert_the_renaming_of_jar_file branch March 11, 2021 18:35
hpkuppuraj added a commit to hpkuppuraj/security that referenced this pull request Jul 13, 2022
Updated the ACS endpoint builder code components. [BUG] v2.1 security plugin is still using _opendistro/_security/saml/acs opensearch-project#1031
hpkuppuraj added a commit to hpkuppuraj/security that referenced this pull request Jul 13, 2022
hpkuppuraj added a commit to hpkuppuraj/security that referenced this pull request Jul 14, 2022
Updated the ACS endpoint builder code components. [BUG] v2.1 security plugin is still using _opendistro/_security/saml/acs opensearch-project#1031

Signed-off-by: hari prasad <prasad.hari@lotuss.com>
hpkuppuraj added a commit to hpkuppuraj/security that referenced this pull request Jul 23, 2022
Updated the ACS endpoint builder code components. [BUG] v2.1 security plugin is still using _opendistro/_security/saml/acs opensearch-project#1031

Signed-off-by: hari prasad <prasad.hari@lotuss.com>
peternied added a commit to hpkuppuraj/security that referenced this pull request Jul 26, 2022
Updated the ACS endpoint builder code components. [BUG] v2.1 security plugin is still using _opendistro/_security/saml/acs opensearch-project#1031

Signed-off-by: hari prasad <prasad.hari@lotuss.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants