Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremented version to 1.3.2. #976

Closed
wants to merge 5 commits into from

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Apr 29, 2022

Signed-off-by: Zelin Hao zelinhao@amazon.com

Description

Incremented version to 1.3.2.

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Issues Resolved

part of opensearch-project/opensearch-build#1882

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh zelinh requested a review from a team April 29, 2022 00:17
@codecov-commenter
Copy link

Codecov Report

Merging #976 (0edd918) into 1.3 (f797354) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              1.3     #976   +/-   ##
=======================================
  Coverage   71.98%   71.98%           
=======================================
  Files          87       87           
  Lines        1906     1906           
  Branches      247      242    -5     
=======================================
  Hits         1372     1372           
  Misses        480      480           
  Partials       54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f797354...0edd918. Read the comment docs.

@peternied
Copy link
Member

Note; this change cannot be merged until there is a successful 13.2 distribution build with security for the integration tests to run against.

@cliu123
Copy link
Member

cliu123 commented Apr 29, 2022

The https://ci.opensearch.org... link gets access denied.

@@ -9,12 +9,12 @@ jobs:
steps:
- name: Download OpenSearch Core
run: |
wget https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.1/latest/linux/x64/builds/opensearch/dist/opensearch-min-1.3.1-linux-x64.tar.gz
wget https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.2/latest/linux/x64/builds/opensearch/dist/opensearch-min-1.3.2-linux-x64.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wget https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.2/latest/linux/x64/builds/opensearch/dist/opensearch-min-1.3.2-linux-x64.tar.gz
wget https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.2/latest/linux/x64/tar/builds/opensearch/dist/opensearch-min-1.3.2-linux-x64.tar.gz

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cliu123 Thanks for the suggestions. I updated the changes in new commit.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@peternied
Copy link
Member

Waiting on opensearch-project/opensearch-build#2067 to be merged so integration tests can run

@peternied
Copy link
Member

@zelinh it looks like GitHub is requesting for the changes to be rebased before it can be merged. Let me know if you'd like a hand with this.

@zelinh zelinh closed this May 2, 2022
@zelinh zelinh deleted the increment-to-1.3.2 branch May 2, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants