Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enforce authentication on api/status route by default" #948

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Apr 16, 2022

Reverts #943. The change was planned to be merged after 2.0.0-rc1.

@cliu123 cliu123 requested a review from a team April 16, 2022 00:37
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #948 (aa2cc97) into main (350e605) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #948   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files          87       87           
  Lines        1906     1906           
  Branches      242      242           
=======================================
  Hits         1375     1375           
  Misses        477      477           
  Partials       54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 350e605...aa2cc97. Read the comment docs.

@peterzhuamazon
Copy link
Member

@cliu123 you need DCO on this one.

@cliu123 cliu123 closed this Apr 16, 2022
@peternied peternied deleted the revert-943-enforce_authentication_on_status_api_by_default branch November 30, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants