Bumps version of main to 2.0.0.0 #928

DarshitChanpura · 2022-03-25T15:11:40Z

Description

Bumps version to 2.0.0.0

Issues resolved

Resolves Ensure plugins work with Dashboards Node v14.18.2 #875

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

DarshitChanpura · 2022-03-25T15:16:34Z

This build requires 2.0.0.0 artifact for opensearch-security and hence can only be merged after backend is updated.
See: #1698

DarshitChanpura · 2022-03-28T13:41:15Z

The test-build seems to be failing because it needs node version upgrade to node@14.18.2, and the PR: #924 is failing because it needs version to be upgraded to 2.0.0.0 which inherently creates a deadlock. How should we proceed @opensearch-project/security ?

peternied · 2022-03-28T13:49:35Z

@DarshitChanpura Can we do both changes in the same PR?

DarshitChanpura · 2022-03-28T13:59:27Z

This build requires 2.0.0.0 artifact for opensearch-security and hence can only be merged after backend is updated. See: #1698

On top of node 14 upgrade, this still stands true. This build requires 2.0.0.0 artifact built for opensearch-security

@DarshitChanpura Can we do both changes in the same PR?

Okay I will bring node14 upgrade changes in this PR.

codecov-commenter · 2022-03-28T14:26:23Z

Codecov Report

Merging #928 (e8de1fb) into main (fc7b8cc) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
+ Coverage   71.98%   72.14%   +0.15%     
==========================================
  Files          87       87              
  Lines        1906     1906              
  Branches      247      242       -5     
==========================================
+ Hits         1372     1375       +3     
+ Misses        480      477       -3     
  Partials       54       54

Impacted Files	Coverage Δ
...plugins/security-dashboards-plugin/public/index.ts	`0.00% <0.00%> (ø)`
.../apps/configuration/panels/role-view/role-view.tsx	`86.30% <0.00%> (+4.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc7b8cc...e8de1fb. Read the comment docs.

.github/workflows/unit-test.yml

DarshitChanpura · 2022-03-29T17:37:34Z

I'm trying to debug Unit tests which fail due to mismatch in Jest snapshot matching: See here

Meanwhile if you know anything about this error please let me know.

DarshitChanpura · 2022-03-29T18:45:09Z

I'm trying to debug Unit tests which fail due to mismatch in Jest snapshot matching: See here

Meanwhile if you know anything about this error please let me know.

I'm unable to reproduce it on local. All the unit tests pass when I run them in the same setup.

Steps that I followed to run the unit tests:

Fork core dashboards (main branch)
Install security plugin (version-bump-2.0.0.0 branch)
Run the tests with this command: node ./test/run_jest_tests.js --config ./test/jest.config.ui.js

peternied · 2022-04-06T17:53:45Z

@DarshitChanpura Looks like there are some unit tests failures, Seperately, I'm looking into the integration test failures, I know we will need a code change for at least one of them

DarshitChanpura · 2022-04-06T18:09:05Z

@DarshitChanpura Looks like there are some unit tests failures, Seperately, I'm looking into the integration test failures, I know we will need a code change for at least one of them

I have fixed unit tests and will push the change soon

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

DarshitChanpura · 2022-04-07T15:05:19Z

We can re-run the integration tests job once security plugin is added to opensearch-build manifest for 2.0.0

.github/workflows/integration-test.yml

peternied · 2022-04-07T15:21:43Z

@DarshitChanpura Note; this is still waiting on opensearch-project/opensearch-build#1924 to be merged and a new build has been produced

peternied · 2022-04-07T21:03:17Z

common/index.ts

@@ -44,5 +44,6 @@ export enum AuthType {
 */
 export function isValidResourceName(resourceName: string): boolean {
  // see: https://javascript.info/regexp-unicode
-  return !/[\p{C}%]/u.test(resourceName) && resourceName.length > 0;
+  const exp = new RegExp('[p{C}%]', 'u');


I think this is going to match the p character, I think you need \p{C} if you want to make sure that we are looking for 'other' unicode characters

…oves test workflow filter for branches Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

peternied

Looks good!

davidlago · 2022-04-07T21:20:59Z

public/apps/account/test/__snapshots__/account-nav-button.test.tsx.snap

@@ -16,7 +16,7 @@ exports[`Account navigation button renders 1`] = `
    id="actionsMenu"
    isOpen={false}
    onClick={[Function]}
-    ownFocus={false}
+    ownFocus={true}


maybe this was asked before, but why this change?

this is because the unit test were failing due to jest snapshot mismatch... this is something worth the discussion.

Note, this control was likely modified by a change in the styles from OpenSearch-Dashboards. We should follow up and confirm that our UI looks clean and behaves as expected between 1.3.X and this 2.0.0 version.

I've created #938 for following up on this.

public/apps/configuration/panels/audit-logging/_index.scss

peternied · 2022-04-07T21:29:28Z

server/auth/types/basic/routes.ts

@@ -171,7 +171,7 @@ export class BasicAuthRoutes {
            ? this.coreSetup.http.basePath.serverBasePath
            : '/';
          const requestQuery = request.url.query as ParsedUrlQueryParams;
-          if (requestQuery.nextUrl !== undefined) {
+          if (requestQuery?.nextUrl !== undefined) {


I've created #936 to follow up, we should stop using the legacy url.query method

DarshitChanpura requested a review from a team March 25, 2022 15:11

DarshitChanpura changed the title ~~Bumps version to 2.0.0.0~~ Bumps version of main to 2.0.0.0 Mar 25, 2022

DarshitChanpura changed the title ~~Bumps version of main to 2.0.0.0~~ Bumps version of main to 2.0.0.0 Mar 25, 2022

This was referenced Mar 25, 2022

Replace _opendistro route with _plugins #895

Merged

upgrade to node14 #924

Closed

peternied previously approved these changes Mar 25, 2022

View reviewed changes

DarshitChanpura dismissed peternied’s stale review via 4147816 March 28, 2022 14:15

DarshitChanpura force-pushed the version-bump-2.0.0.0 branch from 797ef16 to 4147816 Compare March 28, 2022 14:15

DarshitChanpura mentioned this pull request Mar 28, 2022

Ensure plugins work with Dashboards Node v14.18.2 #875

Closed

DarshitChanpura force-pushed the version-bump-2.0.0.0 branch 4 times, most recently from aad2111 to f1a284e Compare March 28, 2022 18:24

peternied reviewed Mar 28, 2022

View reviewed changes

.github/workflows/unit-test.yml Show resolved Hide resolved

DarshitChanpura mentioned this pull request Mar 28, 2022

Updates Dev guide #897

Merged

1 task

DarshitChanpura force-pushed the version-bump-2.0.0.0 branch from f1a284e to 8e6986d Compare March 28, 2022 19:36

peternied added the v2.0.0 label Mar 31, 2022

DarshitChanpura force-pushed the version-bump-2.0.0.0 branch 2 times, most recently from 1318b4e to c8efd79 Compare April 6, 2022 17:44

DarshitChanpura mentioned this pull request Apr 6, 2022

Replaces sasslint to stylelint to conform to changes in core dashboards #933

Closed

1 task

DarshitChanpura force-pushed the version-bump-2.0.0.0 branch from c8efd79 to 560069a Compare April 6, 2022 18:13

DarshitChanpura force-pushed the version-bump-2.0.0.0 branch 2 times, most recently from ca304c8 to 6a43aa6 Compare April 6, 2022 18:17

Fixes failing tests due to snapshot mismatch

b037242

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

DarshitChanpura force-pushed the version-bump-2.0.0.0 branch from 6a43aa6 to 80687fe Compare April 6, 2022 18:18

Replaces sasslint to stylelint to conform to changes in core dashboards

bfe2321

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

DarshitChanpura force-pushed the version-bump-2.0.0.0 branch from 80687fe to 3da4006 Compare April 6, 2022 19:13

peternied reviewed Apr 7, 2022

View reviewed changes

.github/workflows/integration-test.yml Outdated Show resolved Hide resolved

DarshitChanpura force-pushed the version-bump-2.0.0.0 branch 4 times, most recently from 5c39f76 to 715580c Compare April 7, 2022 21:01

peternied requested changes Apr 7, 2022

View reviewed changes

DarshitChanpura force-pushed the version-bump-2.0.0.0 branch from 715580c to fc13901 Compare April 7, 2022 21:07

Bumps artifact version to 2.0.0.0 and updates node to 14.18.2 and rem…

01fc571

…oves test workflow filter for branches Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

DarshitChanpura force-pushed the version-bump-2.0.0.0 branch from fc13901 to 01fc571 Compare April 7, 2022 21:08

peternied reviewed Apr 7, 2022

View reviewed changes

peternied approved these changes Apr 7, 2022

View reviewed changes

davidlago reviewed Apr 7, 2022

View reviewed changes

public/apps/configuration/panels/audit-logging/_index.scss Show resolved Hide resolved

peternied reviewed Apr 7, 2022

View reviewed changes

davidlago approved these changes Apr 8, 2022

View reviewed changes

peternied merged commit afa8f13 into opensearch-project:main Apr 8, 2022

peternied mentioned this pull request Apr 8, 2022

[BUG] Build is broken in main due to version bump #932

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumps version of main to 2.0.0.0 #928

Bumps version of main to 2.0.0.0 #928

DarshitChanpura commented Mar 25, 2022 •

edited

Loading

DarshitChanpura commented Mar 25, 2022 •

edited

Loading

DarshitChanpura commented Mar 28, 2022

peternied commented Mar 28, 2022

DarshitChanpura commented Mar 28, 2022

codecov-commenter commented Mar 28, 2022 •

edited

Loading

DarshitChanpura commented Mar 29, 2022

DarshitChanpura commented Mar 29, 2022 •

edited

Loading

peternied commented Apr 6, 2022

DarshitChanpura commented Apr 6, 2022

DarshitChanpura commented Apr 7, 2022

peternied commented Apr 7, 2022 •

edited

Loading

peternied Apr 7, 2022 •

edited

Loading

peternied left a comment

davidlago Apr 7, 2022

DarshitChanpura Apr 8, 2022

peternied Apr 8, 2022

peternied Apr 7, 2022

Bumps version of main to 2.0.0.0 #928

Bumps version of main to 2.0.0.0 #928

Conversation

DarshitChanpura commented Mar 25, 2022 • edited Loading

Description

Issues resolved

Category

Check List

DarshitChanpura commented Mar 25, 2022 • edited Loading

DarshitChanpura commented Mar 28, 2022

peternied commented Mar 28, 2022

DarshitChanpura commented Mar 28, 2022

codecov-commenter commented Mar 28, 2022 • edited Loading

Codecov Report

DarshitChanpura commented Mar 29, 2022

DarshitChanpura commented Mar 29, 2022 • edited Loading

peternied commented Apr 6, 2022

DarshitChanpura commented Apr 6, 2022

DarshitChanpura commented Apr 7, 2022

peternied commented Apr 7, 2022 • edited Loading

peternied Apr 7, 2022 • edited Loading

Choose a reason for hiding this comment

peternied left a comment

Choose a reason for hiding this comment

davidlago Apr 7, 2022

Choose a reason for hiding this comment

DarshitChanpura Apr 8, 2022

Choose a reason for hiding this comment

peternied Apr 8, 2022

Choose a reason for hiding this comment

peternied Apr 7, 2022

Choose a reason for hiding this comment

DarshitChanpura commented Mar 25, 2022 •

edited

Loading

DarshitChanpura commented Mar 25, 2022 •

edited

Loading

codecov-commenter commented Mar 28, 2022 •

edited

Loading

DarshitChanpura commented Mar 29, 2022 •

edited

Loading

peternied commented Apr 7, 2022 •

edited

Loading

peternied Apr 7, 2022 •

edited

Loading