[Backport 2.11] Threat intel feed support for detector creation (#762) #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 2.11 #769 +/- ##
==========================================
- Coverage 31.38% 31.17% -0.22%
==========================================
Files 150 151 +1
Lines 4923 5008 +85
Branches 883 910 +27
==========================================
+ Hits 1545 1561 +16
- Misses 3193 3257 +64
- Partials 185 190 +5 |
AWSHurneyt
approved these changes
Oct 26, 2023
amsiglan
added a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
Nov 8, 2023
amsiglan
added a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
Nov 8, 2023
…roject#762) (opensearch-project#769)" This reverts commit 64982b9. Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Revert "Make notifications optional 2.11 (#770)" This reverts commit de6001a. Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Revert "Threat intel feed support for detector creation (#762) (#769)" This reverts commit 64982b9. Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Revert "[Backport 2.11] Improved display of log types. (#766)" This reverts commit 25901f6. Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed cypress workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #762 to 2.11
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.