[Backport 2.9] Added support for editing correlation rule (#643) #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added support for editing correlation rule Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed query deletion; api method Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * removed logs Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed rule expression builder Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
lezzago
approved these changes
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## 2.9 #646 +/- ##
==========================================
- Coverage 32.66% 32.51% -0.15%
==========================================
Files 139 139
Lines 4491 4527 +36
Branches 750 748 -2
==========================================
+ Hits 1467 1472 +5
- Misses 2847 2878 +31
Partials 177 177 |
AWSHurneyt
approved these changes
Jul 12, 2023
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…pensearch-project#646) * added support for editing correlation rule * fixed query deletion; api method * removed logs * fixed rule expression builder --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport for PR #643 to 2.9 branch
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.