-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes PageHeader and SideNav #1123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
riysaxen-amzn
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
August 30, 2024 17:37
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
amsiglan
reviewed
Aug 30, 2024
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
amsiglan
approved these changes
Sep 3, 2024
UTs passing locally
|
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
riysaxen-amzn
changed the title
[Part 1] Bug fixes PageHeader and SideNav
Bug fixes PageHeader and SideNav
Sep 3, 2024
AWSHurneyt
approved these changes
Sep 3, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-1123-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dad5ee2ebbffa897e2b6c4fca8b26f6fca16289b
# Push it to GitHub
git push --set-upstream origin backport-1123-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.x Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
* bug fixes related to mds suppport Signed-off-by: Riya Saxena <riysaxen@amazon.com> * bug fixes related to mds suppport Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fixes with mds Signed-off-by: Riya Saxena <riysaxen@amazon.com> * routes changed Signed-off-by: Riya Saxena <riysaxen@amazon.com> * routes changed Signed-off-by: Riya Saxena <riysaxen@amazon.com> * updated snapshot files Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> (cherry picked from commit dad5ee2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn
pushed a commit
that referenced
this pull request
Sep 3, 2024
* bug fixes related to mds suppport * bug fixes related to mds suppport * fixes with mds * routes changed * routes changed * updated snapshot files --------- (cherry picked from commit dad5ee2) Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opensearch-security-analytics
notopensearch_security_analytics
Issues Resolved
SA-mds.mov
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.