Added check before running husky install during post install #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
riysaxen-amzn
approved these changes
May 2, 2024
AWSHurneyt
approved these changes
May 2, 2024
|
Test failure for Windows unrelated to the change in this PR |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit d3aced1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit d3aced1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 9, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit d3aced1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During bootstrap, postinstall script in OSD triggers the postinstall script of all the children repos due to which the path from the security analytics' script gets called is not setup correctly. This PR adds a check to ensure the
husky installonly runs when running from within the SA repo during first time setup for development.Issues Resolved
#987
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.