Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MAINTAINERS.md format. #77

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

dblock
Copy link
Member

@dblock dblock commented Jan 5, 2023

Coming from opensearch-project/.github#121, updated MAINTAINERS.md to match opensearch-project recommended format.

@dblock dblock requested a review from a team January 5, 2023 18:47
@codecov-commenter
Copy link

Codecov Report

Merging #77 (beff47b) into main (d654ad6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #77   +/-   ##
=========================================
  Coverage     65.52%   65.52%           
  Complexity      172      172           
=========================================
  Files            29       29           
  Lines           879      879           
  Branches        119      119           
=========================================
  Hits            576      576           
  Misses          254      254           
  Partials         49       49           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dblock
Copy link
Member Author

dblock commented Jan 5, 2023

Looks like some CI has failed. This change has no code changes, can someone please take a look at that?

@macohen
Copy link
Collaborator

macohen commented Jan 5, 2023

Just disabled the pull_request action which fails when merging something from another fork as per: #66. I haven't yet asked if it's possible to change the setting mentioned in #66 (comment) and I would rather have the action create a new issue with pull request stats on a schedule anyway. Merging the PR...

@dblock
Copy link
Member Author

dblock commented Jan 5, 2023

Just disabled the pull_request action which fails when merging something from another fork as per: #66. I haven't yet asked if it's possible to change the setting mentioned in #66 (comment) and I would rather have the action create a new issue with pull request stats on a schedule anyway. Merging the PR...

Thanks, not sure what that does, but contributions from forks is ... most contributions. Will you please take care of doing the right thing about it? I'll be happy with a new GH issue.

@dblock dblock deleted the updated-maintainers branch January 5, 2023 22:38
@noCharger noCharger added the backport 2.x Backport to 2.x branch label Jan 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 6, 2023
#77)

Signed-off-by: dblock <dblock@amazon.com>

Signed-off-by: dblock <dblock@amazon.com>
(cherry picked from commit 657ebe5)
noCharger pushed a commit that referenced this pull request Jan 6, 2023
…-project format. (#77) (#78)

Signed-off-by: dblock <dblock@amazon.com>
(cherry picked from commit 657ebe5)
@mingshl mingshl added the documentation Improvements or additions to documentation label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants