Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 8.5 #213

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Upgrade to Gradle 8.5 #213

merged 2 commits into from
Dec 19, 2023

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented Dec 12, 2023

This is in preparation for the upgrade to JDK 21.

Description

This is in preparation for the upgrade to JDK 21.

Issues Resolved

Related to opensearch-project/OpenSearch#10334

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This is in preparation for the upgrade to JDK 21.

Signed-off-by: Michael Froh <froh@amazon.com>
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7570dd) 83.30% compared to head (bc79a41) 83.30%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #213   +/-   ##
=========================================
  Coverage     83.30%   83.30%           
  Complexity      337      337           
=========================================
  Files            43       43           
  Lines          1270     1270           
  Branches        155      155           
=========================================
  Hits           1058     1058           
  Misses          134      134           
  Partials         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link

reta commented Dec 12, 2023

@msfroh could you please add JDK-21 to build matrix (Github Actions)? thank you

Signed-off-by: Michael Froh <froh@amazon.com>
@msfroh msfroh merged commit af87aa7 into opensearch-project:main Dec 19, 2023
21 checks passed
@sejli sejli added the backport 2.x Backport to 2.x branch label Feb 28, 2024
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-213-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 af87aa78a352ba7e4e61004165f361814243a4e3
# Push it to GitHub
git push --set-upstream origin backport/backport-213-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-213-to-2.x.

sejli pushed a commit to sejli/search-processor that referenced this pull request Feb 28, 2024
noCharger pushed a commit that referenced this pull request Mar 1, 2024
(cherry picked from commit af87aa7)

Co-authored-by: Michael Froh <froh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants