Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch index settings asynchronously #135

Merged
merged 1 commit into from
May 5, 2023

Commits on May 2, 2023

  1. Fetch index settings asynchronously

    In some cases, like using ./gradlew run, I've run into issues where
    OpenSearch crashes, complaining that we're making a blocking call on a
    listener thread, because we fetch index settings to see if a result
    transformer has been configured for the current index.
    
    I'm kind of surprised that we haven't run into this in production
    use-cases, but it may just be because assertions are not enabled in
    production. Regardless, blocking calls on listener threads are a bad
    idea, since that's how you run out of listener threads.
    
    This change makes the index settings call asynchronous and chains the
    remaining logic off of that.
    
    Signed-off-by: Michael Froh <froh@amazon.com>
    msfroh committed May 2, 2023
    Configuration menu
    Copy the full SHA
    45cc0df View commit details
    Browse the repository at this point in the history