Disable plugin if configFilePath is not present #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sruti1312
requested review from
a team,
sgup432 and
dzane17
and removed request for
sgup432
sgup432
previously approved these changes
Apr 27, 2022
Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312
force-pushed
the
feature/disable-plugin
branch
from
8432acb
to
9e99fdc
Compare
dzane17
approved these changes
Apr 28, 2022
kkhatua
reviewed
Apr 28, 2022
| @@ -65,8 +55,8 @@ public class PluginSettings { | |||
|
|
|||
| private boolean httpsEnabled; | |||
| private Properties settings; | |||
| private final String configFolderPath; | |||
| private final String configFilePath; | |||
| private String configFolderPath; | |||
There was a problem hiding this comment.
nit: Any reason why this isn't final any more?
kkhatua
approved these changes
Apr 28, 2022
sruti1312
added a commit
that referenced
this pull request
May 11, 2022
Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312
added a commit
that referenced
this pull request
May 17, 2022
* Update folder names (#166) Signed-off-by: sruti1312 <srutiparthiban@gmail.com> * Update PA directories from plugins to root (#168) Signed-off-by: sruti1312 <srutiparthiban@gmail.com> * Update configFilePath location (#172) Signed-off-by: sruti1312 <srutiparthiban@gmail.com> * Disable plugin if configFilePath is not present (#173) Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sruti1312 srutiparthiban@gmail.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Disable plugin if configFilePath is not present
Describe the solution you are proposing
Disable plugin if configFilePath is not present
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.