-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some unexpected things looking carefully at https://github.com/opensearch-project/opensearch-net-abstractions/pull/19/files?w=1
SkipReason = skipReason ?? "skipped"; | ||
|
||
public int Timeout => 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks new, why was it added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xunit
was updated and interface TestMethodTestCase
got a new method Timeout
which should be overloaded.
@@ -7,7 +7,9 @@ | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="SemanticVersioning" Version="0.8.0" /> | |||
<PackageReference Include="System.Text.Json" Version="4.6.0" /> | |||
<PackageReference Include="System.Net.Http" Version="4.3.4" /> | |||
<PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks added, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are essential packages, compilation fails without them.
I'm also surprised how it was working before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh 🤔
Signed-off-by: Yury-Fridlyand yuryf@bitquilltech.com
Description
Update some Nuget packages which had dependencies with critical CVEs reported.
See opensearch-project/opensearch-net#88 for more info about security update.
Issues Resolved
CVE-2021-26701
inSystem.Text.Encodings.Web
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.