Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding security analytics dashboards plugin. #382

Closed
wants to merge 6 commits into from
Closed

Onboarding security analytics dashboards plugin. #382

wants to merge 6 commits into from

Conversation

AWSHurneyt
Copy link
Contributor

Description

Onboarding security analytics dashboards plugin. Security analytics 3.0 isn't available yet (currently, it is set to version 2.4), so the checks are expected to fail for now. This PR #380 will onboard security analytics directly to the 2.x branch.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt
Added security analytics dashboards.
2165db6 
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Fixed url is visit() call.
8cc5492 
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt AWSHurneyt requested a review from a team as a code owner November 7, 2022 21:38
@AWSHurneyt AWSHurneyt mentioned this pull request Nov 7, 2022
Closed
1 task
kavilla
kavilla requested changes Nov 8, 2022
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overwriting functions used by other plugins.

@AWSHurneyt
clean up commands
533726d 
Signed-off-by: Kawika Avilla <avillk@amazon.com>
@tianleh
Copy link
Member

tianleh commented Nov 8, 2022

@AWSHurneyt Please check the workflow failure https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3415650616/jobs/5685003590

@AWSHurneyt
Copy link
Contributor Author

@AWSHurneyt Please check the workflow failure https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3415650616/jobs/5685003590

@tianleh The security analytics back and frontend plugins are currently set to version 2.4, so 3.0 artifacts aren't available. That seems to be the cause of the failure.

@tianleh
Copy link
Member

tianleh commented Nov 8, 2022

@tianleh The security analytics back and frontend plugins are currently set to version 2.4, so 3.0 artifacts aren't available. That seems to be the cause of the failure.

In this case, please notify on the thread when it is ready for review. (when 3.0 artifact has your changes)

@AWSHurneyt AWSHurneyt marked this pull request as draft November 8, 2022 18:47
@AWSHurneyt
Copy link
Contributor Author

@tianleh The security analytics back and frontend plugins are currently set to version 2.4, so 3.0 artifacts aren't available. That seems to be the cause of the failure.

In this case, please notify on the thread when it is ready for review. (when 3.0 artifact has your changes)

@tianleh Will do. For now, I'll revert this PR back to a draft as well.

kavilla
kavilla reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding your plugin to the site section as well!

cypress/integration/plugins/security-analytics-dashboards-plugin/rules_spec.js Outdated Show resolved Hide resolved
cypress/utils/plugins/security-analytics-dashboards-plugin/commands.js Outdated Show resolved Hide resolved
cypress/utils/plugins/security-analytics-dashboards-plugin/constants.js Show resolved Hide resolved
@AWSHurneyt AWSHurneyt mentioned this pull request Nov 9, 2022
Closed
@seraphjiang seraphjiang requested review from a team and tianleh November 10, 2022 01:54
@tianleh
Copy link
Member

tianleh commented Feb 1, 2023

@AWSHurneyt The PR is still in draft status. Are you ready to move it to be ready for review? If not needed, could you close the PR?

@AWSHurneyt
Copy link
Contributor Author

AWSHurneyt commented Feb 1, 2023 •
edited
Loading

@AWSHurneyt The PR is still in draft status. Are you ready to move it to be ready for review? If not needed, could you close the PR?

@tianleh
I'll close this PR for now as the security analytics plugin backend main branch is still set to 2.5. I'll check with the team to see if we can get bumped to 3.0 now that the alerting plugin has been bumped to 3.0, and will reopen this PR once it's ready.

@AWSHurneyt AWSHurneyt closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla requested changes

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler will be requested when the pull request is marked ready for review ohltyler is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang will be requested when the pull request is marked ready for review CCongWang is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc will be requested when the pull request is marked ready for review ashwin-pc is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon will be requested when the pull request is marked ready for review peterzhuamazon is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh will be requested when the pull request is marked ready for review ananzh is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi will be requested when the pull request is marked ready for review prudhvigodithi is a code owner

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws will be requested when the pull request is marked ready for review xluo-aws is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am will be requested when the pull request is marked ready for review Hailong-am is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe will be requested when the pull request is marked ready for review SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl will be requested when the pull request is marked ready for review ruanyl is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam will be requested when the pull request is marked ready for review wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao will be requested when the pull request is marked ready for review raintygao is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu will be requested when the pull request is marked ready for review zhongnansu is a code owner

@yujin-emma yujin-emma Awaiting requested review from yujin-emma yujin-emma will be requested when the pull request is marked ready for review yujin-emma is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AWSHurneyt @tianleh @kavilla