[Windows Container] Add #337 #338 AMI and add new customDeviceMapping config with new benchmark agent #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tomDeviceMapping config with new benchmark agent Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
This was referenced Aug 25, 2023
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
rishabh6788
reviewed
Aug 25, 2023
lib/ci-stack.ts
Outdated
| @@ -161,6 +161,7 @@ export class CIStack extends Stack { | |||
| agentNode.AL2_ARM64_DOCKER_HOST, | |||
| agentNode.AL2023_ARM64_DOCKER_HOST, | |||
| agentNode.AL2023_X64_DOCKER_HOST_BENCHMARK_TEST, | |||
| agentNode.AL2023_X64_DOCKER_HOST_BENCHMARK_TEST_NEW_SPEC, | |||
There was a problem hiding this comment.
I think this is a good opportunity to remove "DOCKER" from the agent label as we run everything on the localhost and not inside a CI docker container. @peterzhuamazon
There was a problem hiding this comment.
Will change, thanks!
|
LGTM, please take care of the name change for the benchmark host. |
rishabh6788
approved these changes
Aug 25, 2023
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
deleted the
add-337-338-ami-and-new-customDeviceMapping-with-new-benchmarkagent
branch
71 tasks
peterzhuamazon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Windows Container] Add #337 #338 AMI and add new customDeviceMapping config with new benchmark agent
Issues Resolved
#337
#338
Benchmark Host NewSpecs
opensearch-project/opensearch-build#3743
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.