Refactor releaseTag workflow and add tests #4974
Conversation
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
requested review from
dblock,
peterzhuamazon,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4974 +/- ##
==========================================
+ Coverage 92.17% 92.44% +0.26%
==========================================
Files 197 197
Lines 6634 6654 +20
==========================================
+ Hits 6115 6151 +36
+ Misses 519 503 -16 ☔ View full report in Codecov by Sentry. |
| @@ -58,7 +58,7 @@ pipeline { | |||
| steps { | |||
| echo 'Triggering manifest lock workflow' | |||
| build job: 'release-manifest-commit-lock', wait: true, parameters: [ | |||
| string(name: 'RELEASE_VERSION', value: "${params.RELEASE_VERSION}"), | |||
| string(name: 'RELEASE_VERSION', value: "${params.VERSION}"), | |||
There was a problem hiding this comment.
How we lock the manifest to tag in this triggered job? We have a product parameters in this tag creation job but seems like we locked both OS & OSD manifests with tags in one job.
There was a problem hiding this comment.
We are in discussion to merge both OS and OSD tag creation into one run.
There was a problem hiding this comment.
Modified the workflow to accommodate both OS and OSD tag creation. In this way manifest lock would also happen once and for all.
Thanks!
gaiksaya
changed the title
Description
Refactor releaseTag workflow and add tests
Issues Resolved
Closes #4973
closes #2680
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.