Remove macos platform for OSD builds #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
requested review from
dblock,
peterzhuamazon,
bbarani,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
gaiksaya
added
manifest-ci-check
peterzhuamazon
approved these changes
May 28, 2024
|
I am confused to why we're just removing MacOS builds? Is there a plan to re-add it? |
|
Hey @dblock AFAIK the supported build platforms for dashboards are linux and windows, macos is only for OpenSearch #2216. |
Yes, and we are in the process of adding core only arm64, not completed yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OSd build workflows are failing with invalid platform. Fixing the bug https://build.ci.opensearch.org/view/Build/job/distribution-build-opensearch-dashboards/7668/console introduced in #4706
Issues Resolved
#4681
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.