Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows Container] Replace temurin with openjdk in Windows container and tweak docker build better support Windows #3941

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Aug 30, 2023

Description

[Windows Container] Replace temurin with openjdk in Windows container and tweak docker build better support Windows

Issues Resolved

opensearch-project/opensearch-ci#281
#3743

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ild better support

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #3941 (23cc280) into main (7b9c90b) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3941      +/-   ##
==========================================
- Coverage   92.05%   91.81%   -0.25%     
==========================================
  Files         187      187              
  Lines        5667     5667              
==========================================
- Hits         5217     5203      -14     
- Misses        450      464      +14     

see 2 files with indirect coverage changes

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon merged commit fa382bd into opensearch-project:main Aug 30, 2023
12 checks passed
@peterzhuamazon peterzhuamazon deleted the windows-update-jdk branch August 30, 2023 21:34
@peterzhuamazon
Copy link
Member Author

@peterzhuamazon peterzhuamazon changed the title Replace temurin with openjdk in Windows container and tweak docker build better support Windows [Windows Container] Replace temurin with openjdk in Windows container and tweak docker build better support Windows Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants