-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove BWC test for now as BWC framework does not run correctly as well as rpm integTest as it requires root #1990
Remove BWC test for now as BWC framework does not run correctly as well as rpm integTest as it requires root #1990
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
BWC tests should work it's just failing due to security plugin. |
@kavilla Are you taking about OpenSearch dashboards? |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1990 +/- ##
=========================================
Coverage 94.41% 94.41%
Complexity 22 22
=========================================
Files 187 187
Lines 3739 3739
Branches 29 29
=========================================
Hits 3530 3530
Misses 203 203
Partials 6 6 Continue to review full report at Codecov.
|
Merge it now, we can add back later on. |
BWC test were running for OpenSearch Dashboards tar distributions they were actually catching some issues that should be followed up. I guess my question instead of full out removing it from everything we remove the BWC tests from the test manifest being called but otherwise this will just add a few minutes to test run to keep this in it was just show a "failed" notification versus removing this completely. Seems much more is lost here than gained. |
…ly as well as rpm integTest as it requires root (opensearch-project#1990)" This reverts commit 43d52fa. Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…able tar bwc test for 2.0.0 Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…for 2.0.0 (#2009) * Revert "Remove BWC test for now as BWC framework does not run correctly as well as rpm integTest as it requires root (#1990)" This reverts commit 43d52fa. Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Revert #1990 and remove rpm integ/bwc test, and disable tar bwc test for 2.0.0 Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add back debug related output vars Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Remove BWC test for now as BWC framework does not run correctly as well as rpm integTest as it requires root
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.