Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboards] include output integ test for arm64 #1727

Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 9, 2022

Description

Originally when adding integ tests to OpenSearch Dashboards
I didn't want to the pipeline to showed as failed because
arm64 couldn't run the automated testing.

But after:
#1715

ARM64 tests can run in the CI. So this adds outputing the results
of tests for ARM64 OSD.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

n/a

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Originally when adding integ tests to OpenSearch Dashboards
I didn't want to the pipeline to showed as failed because
arm64 couldn't run the automated testing.

But after:
opensearch-project#1715

ARM64 tests can run in the CI. So this adds outputing the results
of tests for ARM64 OSD.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from a team as a code owner March 9, 2022 05:24
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #1727 (103b60a) into main (8e81337) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1727   +/-   ##
=========================================
  Coverage     94.78%   94.78%           
  Complexity       17       17           
=========================================
  Files           169      169           
  Lines          3525     3525           
  Branches         26       26           
=========================================
  Hits           3341     3341           
  Misses          181      181           
  Partials          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e81337...103b60a. Read the comment docs.

@tianleh
Copy link
Member

tianleh commented Mar 9, 2022

Do you recall the exact failure at that time" arm64 couldn't run the automated testing."?

nvm. find the issue created by myself a while ago #1381

@dblock dblock merged commit 969b77a into opensearch-project:main Mar 9, 2022
@kavilla kavilla deleted the avillk/output_osd_arm_test_results branch March 9, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: arm OSD integ test Jenkins link is not put in the Slack notification
4 participants