Resolve #1130 where sed and tee is trying to access files at the same time #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files at the same time Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1458 +/- ##
============================================
- Coverage 94.67% 94.45% -0.22%
- Complexity 0 12 +12
============================================
Files 120 141 +21
Lines 3003 3084 +81
Branches 0 8 +8
============================================
+ Hits 2843 2913 +70
- Misses 160 164 +4
- Partials 0 7 +7
Continue to review full report at Codecov.
|
dblock
approved these changes
Jan 12, 2022
abhinavGupta16
approved these changes
Jan 12, 2022
peternied
reviewed
Jan 12, 2022
docker/release/config/opensearch-dashboards/opensearch-dashboards-docker-entrypoint.sh
Show resolved
Hide resolved
1 task
peterzhuamazon
added a commit
to peterzhuamazon/opensearch-build
that referenced
this pull request
Feb 16, 2022
… files at the same time (opensearch-project#1458) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Resolve #1130 where sed and tee is trying to access files at the same time.
If we use sed to access file while tee, it would sometimes cause a conflict and result in tee creating empty file due to file is then being held by sed.
Therefore, we cat the file, pipe to sed, then tee, would resolve issue.
Also, fixed an error where sed is not correctly setup for the pattern.
Issues Resolved
#1454
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.