-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Dashboards integ test against static endpoint in Jenkins job #1322
Comments
First need to understand how current OpenSearch integ test runs from Jenkins |
A run needs Follow up question: is this automatically run? If yes, how the parameters are passed? On the other hand, if manual run, then parameters can be passed manually. |
One option is once
|
Another option is have a main job to coordinate the build/assemble and then integ test, potentially extending the existing |
DeclarativeJobPropertyTrackerAction.getParameters can only get the input name "INPUT_MANIFEST" but not the actual content of the value. |
To summarize current status, I am able to get the latest OpenSearch and OpenSearchDashboards build number. However, I cannot move further to get the build details. Why is this import? E.g when a OpenSearchDashboards build/assemble is done, it may need to know which build from |
To help explain the POC work, I first try to get the latest build number from This part is working. Next, assume OpenSearchDashboards is the main driver. We want to
Currently I am still researching how to get the build details (INPUT_MANIFEST) from the build number. |
I think using the current check-for-build workflow (https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/check-for-build.jenkinsfile) to trigger a new coordinator workflow that runs build and test workflows might be a lot easier. Trying to build something independent that tries to fetch the last good build feels unnecessarily complicated. |
After talking with @ohltyler about the PR #1429, we figure out the following result. Tyler's work is for running OpenSearch integ test while mine current task is for such in OpenSearch Dashboards. The OpenSearch Dashboards test job will need to know both OpenSearch and OpenSearch Dashboards public endpoints which is very different from OpenSearch tests which just need to know the OpenSearch public endpoint. To further clarify the difference, since currently OpenSearch and OpenSearch Dashboards distribution build jobs are separate, Tyler's work can be done purely inside the OpenSearch build job while my work could potentially require cross-job information. I am currently experimenting the "a new coordinator workflow" from #1322 (comment) which may need to build and test together for both OpenSearch and OpenSearch Dashboards. To summarize, structure wise there won't be reused work from Tyler's PR towards my work. I would vision "the new coordinator workflow" would trigger the OpenSearch integ test logic by Tyler and also my OpenSearch Dashboards logic in this PR #1368 CC @ohltyler @dblock @seraphjiang @kavilla @Tengda-He for visibility |
I think it may be simpler if Dashboards were treated as a separate standalone product, and just use the latest available OpenSearch build, as needed. Do we really need to coordinate the two? |
From the issue description, we need public endpoint of both OpenSearch and OpenSearch Dashboards. |
I see this code that passes endpoint information on. |
We will run the test against the release endpoint instead of every newly bundled artifact. Found a pre-quest task #1482 |
Closed in favor of #704 |
Is your feature request related to a problem? Please describe
#604
Describe the solution you'd like
Currently there is only OpenSearch integ test in Jenkins
opensearch-build/jenkins/test/testsuite/Jenkinsfile
Line 63 in 86f9cbe
We want to add such for Dashboards as well. The challenge is how we know the public urls for OS and OSD to feed into test.sh
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: