Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bwc tests against the distribution #1366

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Add bwc tests against the distribution #1366

merged 2 commits into from
Jan 7, 2023

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Jan 5, 2023

Signed-off-by: Zelin Hao zelinhao@amazon.com

Description

Add option to run BWC tests in distribution level, which is running tests in the test cluster with latest distribution bundle installed and all plugins (included in the latest manifest) present.

The command to run BWC tests in distribution level would be ./gradlew bwcTestSuite -Dtests.security.manager=false -PcustomDistributionDownloadType=bundle
If property customDistributionDownloadType is not set nor set to bundle, the BWC tests would be default to run in plugins level as previously configured.

Issues Resolved

Part of opensearch-project/opensearch-build#2870

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh
Add bwc tests in distribution level
e2a7ac2 
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh zelinh requested a review from a team as a code owner January 5, 2023 00:41
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023 •
edited
Loading

Codecov Report

Merging #1366 (e2a7ac2) into 2.x (d2a17a3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x    #1366   +/-   ##
=========================================
  Coverage     41.89%   41.89%           
  Complexity      315      315           
=========================================
  Files           302      302           
  Lines         17849    17849           
  Branches       4332     4332           
=========================================
  Hits           7477     7477           
  Misses        10199    10199           
  Partials        173      173
Flag Coverage Δ
dashboards-observability 37.33% <ø> (ø)
opensearch-observability 70.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

joshuali925
joshuali925 previously approved these changes Jan 5, 2023
View reviewed changes
opensearch-observability/build.gradle Outdated
node.setting("plugins.security.system_indices.enabled", "true")
}
} else {
versions = ["1.2.0",opensearch_version]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q. how come this works but for bundled test the -SNAPSHOT needs to be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuali925 For this one, we are getting the min artifacts from URL: https://artifacts.opensearch.org/releases/core/opensearch/1.2.0/opensearch-min-1.2.0-linux-x64.tar.gz for released version and https://artifacts.opensearch.org/snapshots/core/opensearch/2.5.0-SNAPSHOT/opensearch-min-2.5.0-SNAPSHOT-linux-x64-latest.tar.gz for unreleased snapshot version;
while we are getting the bundle from CI bucket with URL as https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.5.0/latest/linux/x64/tar/dist/opensearch/opensearch-2.5.0-linux-x64.tar.gz which doesn't contain -SNAPSHOT in the path.

@zelinh
Rebase with upstream
7f2accc 
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh
Copy link
Member Author

zelinh commented Jan 6, 2023

@joshuali925 Please help re-review this PR as I just rebase the branch to resolve conflicts. Thanks!

@joshuali925 joshuali925 merged commit 427a3e3 into opensearch-project:2.x Jan 7, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 7, 2023
@zelinh @github-actions
Add bwc tests in distribution level (#1366)
ffe88e3 
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
(cherry picked from commit 427a3e3)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 7, 2023
Merged
joshuali925 pushed a commit that referenced this pull request Jan 7, 2023
@opensearch-trigger-bot @zelinh
Add bwc tests in distribution level (#1366) (#1371)
51a5e8e 
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
(cherry picked from commit 427a3e3)

Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps48 ps48 ps48 approved these changes

@joshuali925 joshuali925 joshuali925 approved these changes

Assignees
No one assigned
Labels
backport 2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zelinh @codecov-commenter @ps48 @joshuali925