Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor XContentType to mediaType #721

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

Hailong-am
Copy link
Collaborator

Description

  1. update to fix compile issue for refactoring XContentType to mediaType in core
  2. bump bwc version to 2.10.0

Issues Resolved

opensearch-project/OpenSearch#8636

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #721 (a8d26e8) into main (52eaba6) will increase coverage by 4.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #721      +/-   ##
============================================
+ Coverage     61.84%   66.19%   +4.35%     
- Complexity      114      253     +139     
============================================
  Files            73       39      -34     
  Lines          2495     1698     -797     
  Branches        266      158     -108     
============================================
- Hits           1543     1124     -419     
+ Misses          775      456     -319     
+ Partials        177      118      -59     
Flag Coverage Δ
opensearch-notifications 66.19% <ø> (+4.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...org/opensearch/notifications/NotificationPlugin.kt 97.43% <ø> (ø)
...pensearch/notifications/action/PluginBaseAction.kt 43.93% <ø> (+0.65%) ⬆️
...earch/notifications/index/ConfigIndexingActions.kt 60.82% <ø> (+4.14%) ⬆️
...opensearch/notifications/index/ConfigOperations.kt 0.00% <ø> (ø)
...pensearch/notifications/index/ConfigQueryHelper.kt 90.99% <ø> (ø)
...opensearch/notifications/index/EventQueryHelper.kt 0.00% <ø> (ø)
...rch/notifications/index/NotificationConfigIndex.kt 70.12% <ø> (+0.45%) ⬆️
.../org/opensearch/notifications/model/DocMetadata.kt 89.65% <ø> (ø)
...earch/notifications/model/NotificationConfigDoc.kt 100.00% <ø> (ø)
...notifications/model/SendTestNotificationRequest.kt 100.00% <ø> (ø)
... and 8 more

... and 35 files with indirect coverage changes

@Hailong-am Hailong-am merged commit d0a322c into opensearch-project:main Jul 26, 2023
13 checks passed
@Hailong-am Hailong-am deleted the fix_core/media_type branch July 26, 2023 02:50
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-721-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d0a322cb518a5294207b954f8877da6b15629338
# Push it to GitHub
git push --set-upstream origin backport/backport-721-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-721-to-2.x.

Hailong-am added a commit to Hailong-am/notifications that referenced this pull request Aug 7, 2023
Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit d0a322c)
Hailong-am added a commit that referenced this pull request Aug 7, 2023
* Fix core XcontentFactory refactor (#732)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 216dfcb)

* Refactor XContentType to mediaType (#721)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit d0a322c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants