Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MAINTAINERS.md format. #589

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

dblock
Copy link
Member

@dblock dblock commented Jan 5, 2023

Coming from opensearch-project/.github#121, updated MAINTAINERS.md to match opensearch-project recommended format.

@dblock dblock requested a review from a team January 5, 2023 17:45
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #589 (923955e) into main (5b9ff98) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #589   +/-   ##
=========================================
  Coverage     61.36%   61.36%           
  Complexity      112      112           
=========================================
  Files            73       73           
  Lines          2472     2472           
  Branches        265      265           
=========================================
  Hits           1517     1517           
  Misses          778      778           
  Partials        177      177           
Flag Coverage Δ
opensearch-notifications 61.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dblock
Copy link
Member Author

dblock commented Jan 5, 2023

Looks like some CI has failed. This change has no code changes, can someone please take a look at that?

@qreshi
Copy link
Contributor

qreshi commented Jan 5, 2023

Looks like some CI has failed. This change has no code changes, can someone please take a look at that?

Just took a look. The failures for the backend and frontend CI are known flaky test issues. There are tracking issues to address those.

The failure in the Security test CI happened after upgrading to 3.0 (it's related to a dependent library and not from Notifications itself) and the fix for it is currently in review here #583

I think you're good to proceed in merging this PR.

@dblock
Copy link
Member Author

dblock commented Jan 19, 2023

I don't have permissions to this repo. Who's looking at this?

@lezzago lezzago merged commit b5379b6 into opensearch-project:main Jan 24, 2023
@dblock dblock deleted the updated-maintainers branch January 26, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants