Fixing compilation errors after refactoring in core OpenSearch #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
changed the title
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
wujunshen,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
=========================================
Coverage 89.55% 89.55%
Complexity 103 103
=========================================
Files 7 7
Lines 316 316
Branches 52 52
=========================================
Hits 283 283
Misses 16 16
Partials 17 17 |
|
We need to backport to 2.x after core does theirs, so far the label 2.10 is there but actual backport is not done yet. |
junqiu-lei
approved these changes
Jul 28, 2023
heemin32
approved these changes
Jul 28, 2023
navneet1v
pushed a commit
to navneet1v/neural-search
that referenced
this pull request
Aug 17, 2023
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
navneet1v
added a commit
that referenced
this pull request
Aug 17, 2023
….x branch (#253) * Fixed compilation errors after refactoring in core (#249) Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Fixing test classes after core refactoring (#237) Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Fixed compilation errors after refactoring in core Strings class (#243) Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Switch from XContentType to MediaType to fix compilation errors (#232) Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Fixing the Media type being not able to be read from Headers. Signed-off-by: Navneet Verma <navneev@amazon.com> --------- Signed-off-by: Martin Gaievski <gaievski@amazon.com> Signed-off-by: Navneet Verma <navneev@amazon.com> Co-authored-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing compilation errors after core refactored JSON to a static field of XContentType class (core PR ref)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.