Adding Backward Compatibility Tests for k-NN #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
requested review from
a team,
jmazanec15,
junqiu-lei,
vamshin and
VijayanB
VijayanB
reviewed
Nov 19, 2021
|
@naveentatikonda do we need those binary files to be checked in? if not, can you add it to .gitignore files? |
Yes Vijay, we need to check-in the binary files. We need them to run the BWCTests. Those are the gradle assemble zips of previous k-NN plugin versions and libKNNIndexV2_0_11.so |
|
@naveentatikonda could you add in the description whats actions the tests are performing to confirm a change is backwards compatible? |
jmazanec15
reviewed
Nov 22, 2021
naveentatikonda
force-pushed
the
BWC_Tests_k-NN
branch
3 times, most recently
from
3c0e4b9
to
24add37
Compare
VijayanB
reviewed
Nov 23, 2021
VijayanB
reviewed
Nov 23, 2021
src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Nov 23, 2021
src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Nov 23, 2021
src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Nov 23, 2021
src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Nov 23, 2021
src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Nov 23, 2021
src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Nov 23, 2021
src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Nov 23, 2021
VijayanB
reviewed
Nov 23, 2021
VijayanB
reviewed
Nov 23, 2021
src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Nov 23, 2021
src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Nov 23, 2021
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
BWC_Tests_k-NN
branch
from
f98e570
to
201f105
Compare
|
@jmazanec15 @VijayanB updated the code as per our discussion offline |
Codecov Report
@@ Coverage Diff @@
## main #226 +/- ##
=========================================
Coverage 83.21% 83.21%
Complexity 864 864
=========================================
Files 123 123
Lines 3777 3777
Branches 358 358
=========================================
Hits 3143 3143
Misses 474 474
Partials 160 160 Continue to review full report at Codecov.
|
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
jmazanec15
reviewed
Nov 29, 2021
jmazanec15
previously approved these changes
Nov 29, 2021
VijayanB
reviewed
Nov 29, 2021
src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Nov 29, 2021
src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
BWC_Tests_k-NN
branch
from
9a8ff20
to
1c11d8a
Compare
jmazanec15
approved these changes
Nov 29, 2021
VijayanB
approved these changes
Nov 29, 2021
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
* Adding Backward Compatibility Tests for k-NN Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Delete unnecessary Binary files Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Updated Developer Guide and refactored code Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
* Adding Backward Compatibility Tests for k-NN Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Delete unnecessary Binary files Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Updated Developer Guide and refactored code Signed-off-by: Naveen Tatikonda <navtat@amazon.com> Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
* Adding Backward Compatibility Tests for k-NN Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Delete unnecessary Binary files Signed-off-by: Naveen Tatikonda <navtat@amazon.com> * Updated Developer Guide and refactored code Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naveen Tatikonda navtat@amazon.com
Description
Adding Backward Compatibility Tests(Mixed Cluster test, Rolling upgrade test, Full restart upgrade test) to k-NN
Issues Resolved
#84
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.