Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HNSW PQ configuration to perf tests #1089

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

jmazanec15
Copy link
Member

Description

Adds HNSW PQ perf test config to release configs.

Ran on my own machine and got the following results:

  "results": {
    "test_took": 293816.24999604654,
    "delete_model_took_total": 74.6723180054687,
    "delete_index_took_total": 91.5388090070337,
    "train_model_took_total": 98810.09195902152,
    "create_index_took_total": 447.3603710066527,
    "ingest_took_total": 67643.88565102126,
    "refresh_index_store_kb_total": 969579.529296875,
    "refresh_index_took_total": 25093.700887984596,
    "query_took_total": 101655.0,
    "query_took_p50": 10.0,
    "query_took_p90": 11.0,
    "query_took_p99": 12.0,
    "query_took_p99.9": 13.0,
    "query_took_p100": 99.0,
    "query_client_time_total": 121304.0,
    "query_client_time_p50": 12.0,
    "query_client_time_p90": 13.0,
    "query_client_time_p99": 14.0,
    "query_client_time_p99.9": 41.0,
    "query_client_time_p100": 228.0,
    "query_memory_kb_total": 172384.0,
    "query_recall@K_total": 0.629275,
    "query_recall@1_total": 0.9948
  }

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: John Mazanec <jmazane@amazon.com>
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1089 (ce92720) into main (a8eda13) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1089      +/-   ##
============================================
- Coverage     85.01%   84.95%   -0.07%     
  Complexity     1184     1184              
============================================
  Files           159      159              
  Lines          4813     4813              
  Branches        433      433              
============================================
- Hits           4092     4089       -3     
- Misses          525      528       +3     
  Partials        196      196              

see 1 file with indirect coverage changes

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@navneet1v
Copy link
Collaborator

Let make sure that we add the configuration for filters also with HNSW-PQ for faiss. Not in this PR, we can take it as a separate PR.

@jmazanec15 jmazanec15 merged commit 036d060 into opensearch-project:main Sep 1, 2023
51 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants