Reduce test running time #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
============================================
- Coverage 75.72% 74.69% -1.04%
+ Complexity 2845 2779 -66
============================================
Files 364 364
Lines 16266 16263 -3
Branches 2343 2343
============================================
- Hits 12317 12147 -170
- Misses 2607 2817 +210
+ Partials 1342 1299 -43
|
bowenlan-amzn
requested review from
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep,
AWSHurneyt and
jowg-amazon
as code owners
bowenlan-amzn
commented
Oct 2, 2023
| assertEquals(expectedHistory, actualHistory) | ||
|
|
||
| waitFor { assertEquals("true", getIndexBlocksWriteSetting(indexName)) } | ||
| } | ||
|
|
||
| fun `test short retention period and history enabled`() { | ||
| fun `test history write index cannot be deleted if enabled, can be deleted if disabled`() { |
There was a problem hiding this comment.
This IT covers history index rollover, retention(delete old history index that exceeds retention time which is not write index)
And disable history index will delete all history indexes
lezzago
previously approved these changes
Oct 2, 2023
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
lezzago
approved these changes
Oct 3, 2023
jowg-amazon
approved these changes
Oct 3, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-965-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dd50b3eb6d9869f9b4c1d286e8ab9c298dcb73f1
# Push it to GitHub
git push --set-upstream origin backport/backport-965-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.xThen, create a pull request where the |
bowenlan-amzn
added a commit
to bowenlan-amzn/index-management
that referenced
this pull request
Oct 3, 2023
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
bowenlan-amzn
added a commit
to bowenlan-amzn/index-management
that referenced
this pull request
Oct 3, 2023
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
bowenlan-amzn
added a commit
that referenced
this pull request
Oct 3, 2023
Joshua152
pushed a commit
to Joshua152/index-management
that referenced
this pull request
Oct 10, 2023
* Reduce test running time Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Dig into several long running test Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * cleanup Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * debug bwc Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * debug bwc Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * ktlint Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Our long integration test time has always been a pain point. This PR tackles down several long running tests and improve the test time a lot.
RollupActionIT 6m -> 1m
SMRunnnerIT 1m -> 10s
...
All the ValidateIT are removed since those are kind of duplicate to ActionIT, UT is better to substitute those.
Total time 35-40m -> ~26m
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.