Fit and Finish changes for Indexes and Transform pages #1154
Conversation
tandonks
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
|
Not sure if the following files are in scope, but the headers should be
|
|
Should the title in 
|
|
In
|
|
The heading in 
|
|
The context menu here should have 
|
|
Also the titles on the 4 steps of transform job creation should be 
|
|
Should the title in 
|
There was a problem hiding this comment.
The Header should be wrapped in <EuiText size="s"> instead of <EuiTitle size="l"> (on line 765).
| {" "} | ||
| <h2>Apply policy</h2>{" "} | ||
| </EuiText>{" "} | ||
| </EuiModalHeaderTitle> | ||
| </EuiModalHeader> | ||
|
|
||
| <EuiModalBody> |
There was a problem hiding this comment.
Not sure if the text is intentionally xs, should the apply policy paragraph text be wrapped in EuiText size="s" instead?
There was a problem hiding this comment.
Should the title on this page (line 745) be <EuiText size="s"> <h1> instead?
There was a problem hiding this comment.
Should the title on line 277 be wrapped in EuiText size="s" instead?
|
The text for |
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
tandonks
force-pushed
the
fitfinishindexes
branch
from
49256bd
to
063f07b
Compare
* changes for indexes, transform Signed-off-by: Kshitij Tandon <tandonks@amazon.com> * Worked on review Signed-off-by: Kshitij Tandon <tandonks@amazon.com> * Couple of changes for old UI Signed-off-by: Kshitij Tandon <tandonks@amazon.com> * Minor changes to UI Signed-off-by: Kshitij Tandon <tandonks@amazon.com> * Resolved P0 items identified in demo Signed-off-by: Kshitij Tandon <tandonks@amazon.com> * Updated old UI Title sizes Signed-off-by: Kshitij Tandon <tandonks@amazon.com> --------- Signed-off-by: Kshitij Tandon <tandonks@amazon.com> (cherry picked from commit 8a0ae28) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* changes for indexes, transform * Worked on review * Couple of changes for old UI * Minor changes to UI * Resolved P0 items identified in demo * Updated old UI Title sizes --------- (cherry picked from commit 8a0ae28) Signed-off-by: Kshitij Tandon <tandonks@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Did fit and finish changes for Indexes and Transform pages
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.