[Fix] Missing TCP Protocol For Metrics in OpenSearch and OpenSearch Dashboards #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VILJkid
requested review from
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
3 tasks
peterzhuamazon
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Thanks @VILJkid , waiting for @prudhvigodithi to take a second pass.
Signed-off-by: VILJkid <sidvjmostwanted@gmail.com>
VILJkid
force-pushed
the
serviceMonitor
branch
from
648476d
to
40f5455
Compare
prudhvigodithi
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a bug related to the Prometheus monitoring configuration in both the OpenSearch and OpenSearch Dashboards Helm charts. The issue was identified where the
Servicedefinitions for Prometheus were missing theprotocol: TCPsetting. This fix adds that setting to both the charts.Issues Resolved
#588
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changePR sponsored by Obmondo