Add user-defined labels option to ingress #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wigust
requested review from
bbarani,
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
wigust
force-pushed
the
charts-opensearch-ingress-labels
branch
from
278c858
to
f2b68fe
Compare
wigust
force-pushed
the
charts-opensearch-ingress-labels
branch
from
f2b68fe
to
6777ebe
Compare
wigust
force-pushed
the
charts-opensearch-ingress-labels
branch
2 times, most recently
from
05204b2
to
d6e20db
Compare
|
Thanks LGTM, final two things left is please update the chart README section adding |
|
I will take care of this suggestions from my above comment, we can merge this PR. |
prudhvigodithi
approved these changes
Dec 14, 2023
prudhvigodithi
force-pushed
the
charts-opensearch-ingress-labels
branch
from
d6e20db
to
2647a5f
Compare
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
prudhvigodithi
force-pushed
the
charts-opensearch-ingress-labels
branch
from
2647a5f
to
b460fa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #390 allow to add labels to Ingress in charts/opensearch
Issues Resolved
Labels could be used in kube-prometheus-stack monitoring.coreos.com/v1 Probe objects as a selector.
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.