-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding DLS with write permission recommendation #1273 #7668
Merged
Naarcha-AWS
merged 2 commits into
opensearch-project:main
from
AntonEliatra:adding-dls-write-recommendation
Jul 11, 2024
Merged
Adding DLS with write permission recommendation #1273 #7668
Naarcha-AWS
merged 2 commits into
opensearch-project:main
from
AntonEliatra:adding-dls-write-recommendation
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
AntonEliatra
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
July 10, 2024 10:22
hdhalter
added
3 - Tech review
PR: Tech review in progress
security
backport 2.15
labels
Jul 10, 2024
Naarcha-AWS
approved these changes
Jul 10, 2024
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
stephen-crawford
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider phrasing this as a recommendation not a requirement. There is nothing fundamentally wrong with being able to write but not read. Regardless, this is technically correct.
hdhalter
added
4 - Doc review
PR: Doc review in progress
and removed
3 - Tech review
PR: Tech review in progress
labels
Jul 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
* Adding DLS with write permission recommendation #1273 Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update _security/access-control/document-level-security.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> --------- Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> (cherry picked from commit 8fffcbc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-documentation-website-forl
that referenced
this pull request
Jul 24, 2024
… (opensearch-project#7668) * Adding DLS with write permission recommendation opensearch-project#1273 Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update _security/access-control/document-level-security.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> --------- Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
sandervandegeijn
pushed a commit
to sandervandegeijn/documentation-website
that referenced
this pull request
Jul 30, 2024
… (opensearch-project#7668) * Adding DLS with write permission recommendation opensearch-project#1273 Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update _security/access-control/document-level-security.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> --------- Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sander van de Geijn <sandervandegeijn@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding DLS with write permission recommendation
Issues Resolved
Closes #1273
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.