[Data Prepper] MAINT: add HTML comment on obfuscate processor config table #7651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Chen <qchea@amazon.com>
dlvenable
reviewed
Jul 9, 2024
| @@ -62,6 +62,13 @@ When run, the `obfuscate` processor parses the fields into the following output: | |||
|
|
|||
| Use the following configuration options with the `obfuscate` processor. | |||
|
|
|||
| <!-- | |||
| This table is auto generated. | |||
| <!-- | ||
| This table is auto generated. | ||
| - name: obfuscate. | ||
| - pluginType: Processor. |
There was a problem hiding this comment.
Let's use lowercase "processor" to keep as a keyword.
| This table is auto generated. | ||
| - name: obfuscate. | ||
| - pluginType: Processor. | ||
| - source: https://github.com/opensearch-project/data-prepper/blob/main/data-prepper-plugins/obfuscate-processor/src/main/java/org/opensearch/dataprepper/plugins/processor/obfuscation/ObfuscationProcessorConfig.java |
There was a problem hiding this comment.
It may be a good idea to use the commit in the URL rather than main. It will let us know the exact revision used.
Signed-off-by: George Chen <qchea@amazon.com>
chenqi0805
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
stephen-crawford and
epugh
as code owners
Signed-off-by: George Chen <qchea@amazon.com>
kolchfa-aws
reviewed
Jul 11, 2024
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Qi Chen <chenqi0805@gmail.com>
1 task
kolchfa-aws
approved these changes
Jul 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
…table (#7651) * MAINT: add HTML comment Signed-off-by: George Chen <qchea@amazon.com> * MNT: address comments Signed-off-by: George Chen <qchea@amazon.com> * MAINT: period Signed-off-by: George Chen <qchea@amazon.com> * Update _data-prepper/pipelines/configuration/processors/obfuscate.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Qi Chen <chenqi0805@gmail.com> --------- Signed-off-by: George Chen <qchea@amazon.com> Signed-off-by: Qi Chen <chenqi0805@gmail.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> (cherry picked from commit 3f3364a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This serves as a starter to auto-generate config table from our source repo
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Version
List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.