Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Support switch_aliases in shrink action. #5511

Merged
merged 16 commits into from
Feb 1, 2024
Merged

[DOC] Support switch_aliases in shrink action. #5511

merged 16 commits into from
Feb 1, 2024

Conversation

ikibo
Copy link
Contributor

@ikibo ikibo commented Nov 4, 2023 •
edited by hdhalter
Loading

Description

DOC for a new feature in a shrink action: support aliases switch from the source to the target index.

Issues Resolved

Issue Index-management#676
Relates to PR

Fixes #5479

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Support switch_aliases in shrink action DOC.
b49423b 
Signed-off-by: ikibo <oleg.kravchuk@logz.io>
@hdhalter hdhalter added v2.12.0 release-notes PR: Include this PR in the automated release notes labels Nov 6, 2023
hdhalter
hdhalter reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of tweaks. Does the table look good when you test it? It's not formatted correctly in the preview. Thanks!

_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
@hdhalter hdhalter added the 4 - Doc review PR: Doc review in progress label Nov 6, 2023
ikibo and others added 2 commits November 7, 2023 10:30
@ikibo @hdhalter
Update _im-plugin/ism/policies.md
8a6d3b1 
Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com>
@ikibo
Merge branch 'main' into doc-support-switch-aliases-in-shrink-action
e896503
@ikibo
Copy link
Contributor Author

ikibo commented Nov 7, 2023

Just a couple of tweaks. Does the table look good when you test it? It's not formatted correctly in the preview. Thanks!

hi @hdhalter. Yeah, the table is not formatted correctly in the preview. And the thing is that it was not before my changes. None of the tables in this md file look good in a preview.

I am trying to follow the instructions on how to run the documentation site locally to test changes, but I am running into issues installing Ruby and Jekyll

@hdhalter
Copy link
Contributor

hdhalter commented Nov 7, 2023

Just a couple of tweaks. Does the table look good when you test it? It's not formatted correctly in the preview. Thanks!

hi @hdhalter. Yeah, the table is not formatted correctly in the preview. And the thing is that it was not before my changes. None of the tables in this md file look good in a preview.

I am trying to follow the instructions on how to run the documentation site locally to test changes, but I am running into issues installing Ruby and Jekyll

I'm trying to test this locally, too, but having technical difficulties.

hdhalter
hdhalter approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test this locally, and the changes and the table look good. :)
image

@hdhalter
Copy link
Contributor

hdhalter commented Nov 7, 2023 •
edited
Loading

Let me run this through editorial, and then merge to 'main' once approved. Will merge to production for 2.12.

@hdhalter hdhalter added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Nov 7, 2023
@ikibo
Copy link
Contributor Author

ikibo commented Nov 7, 2023

@hdhalter thnnk U ! Amazing!

vagimeli
vagimeli approved these changes Nov 8, 2023
View reviewed changes
_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
ikibo and others added 5 commits November 8, 2023 20:48
@ikibo @vagimeli
Update _im-plugin/ism/policies.md
f0e14bc 
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com>
@ikibo @vagimeli
Update _im-plugin/ism/policies.md
1783dac 
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com>
@ikibo @vagimeli
Update _im-plugin/ism/policies.md
25ab28c 
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com>
@ikibo
Merge branch 'main' into doc-support-switch-aliases-in-shrink-action
51251ba
Data types in TYPE column must be capitalized
f75efb4 
Signed-off-by: ikibo <oleg.kravchuk@logz.io>
@hdhalter
Update policies.md
bd4d020 
Added tick marks to two parameters

Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
@hdhalter hdhalter added 6 - Done but waiting to merge PR: The work is done and ready to merge and removed 5 - Editorial review PR: Editorial review in progress labels Nov 8, 2023
vagimeli
vagimeli approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial review completed. Edits made to tighten or clarify writing.

_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
_im-plugin/ism/policies.md Outdated Show resolved Hide resolved
hdhalter and others added 6 commits November 9, 2023 10:06
@hdhalter @vagimeli
Update _im-plugin/ism/policies.md
be056c6 
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
@hdhalter @vagimeli
Update _im-plugin/ism/policies.md
212a8b9 
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
@hdhalter @vagimeli
Update _im-plugin/ism/policies.md
0c7bccd 
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
@hdhalter @vagimeli
Update _im-plugin/ism/policies.md
0abbb10 
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
@hdhalter @vagimeli
Update _im-plugin/ism/policies.md
e7e99b8 
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
@hdhalter @vagimeli
Update _im-plugin/ism/policies.md
1ed5c6a 
Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
@hdhalter hdhalter merged commit 51499ae into opensearch-project:main Feb 1, 2024
3 checks passed
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 6 - Done but waiting to merge PR: The work is done and ready to merge labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdhalter hdhalter hdhalter approved these changes

@vagimeli vagimeli vagimeli approved these changes

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@ananzh ananzh Awaiting requested review from ananzh

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@natebower natebower Awaiting requested review from natebower natebower is a code owner

Assignees

@ikibo ikibo

Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation related to new feature - Support switch aliases in shrink action
3 participants
@ikibo @hdhalter @vagimeli