Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPM installation instructions #532

Merged
merged 12 commits into from
May 3, 2022
Merged

Add RPM installation instructions #532

merged 12 commits into from
May 3, 2022

Conversation

Naarcha-AWS
Copy link
Collaborator

Signed-off-by: Naarcha-AWS naarcha@amazon.com

Description

Adds installation instructions for RPM through manual and YUM install.

Issues Resolved

Closes #511

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@alicejw1 alicejw1 self-requested a review May 3, 2022 16:29
@Naarcha-AWS Naarcha-AWS marked this pull request as ready for review May 3, 2022 16:42
@Naarcha-AWS Naarcha-AWS requested a review from a team as a code owner May 3, 2022 16:42
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of comment I give here, thanks.

_opensearch/install/rpm.md Outdated Show resolved Hide resolved
_opensearch/install/rpm.md Outdated Show resolved Hide resolved
_opensearch/install/rpm.md Outdated Show resolved Hide resolved
_opensearch/install/rpm.md Show resolved Hide resolved
_opensearch/install/rpm.md Outdated Show resolved Hide resolved
_opensearch/install/rpm.md Outdated Show resolved Hide resolved
_opensearch/install/rpm.md Outdated Show resolved Hide resolved
_opensearch/install/rpm.md Outdated Show resolved Hide resolved
_opensearch/install/rpm.md Outdated Show resolved Hide resolved
_opensearch/install/rpm.md Outdated Show resolved Hide resolved
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
_opensearch/install/rpm.md Outdated Show resolved Hide resolved
_opensearch/install/rpm.md Outdated Show resolved Hide resolved
_opensearch/install/rpm.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added some minor in-line suggestions

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS
Copy link
Collaborator Author

@natebower: This PR is ready for Editorial Review.

@lizsnyder lizsnyder self-requested a review May 3, 2022 21:39
Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@Naarcha-AWS Naarcha-AWS merged commit 009ef9f into main May 3, 2022
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggested changes and let me know if you have any questions. Thanks!


# RPM

The RPM Package Manager (RPM) installation provides everything you need to run OpenSearch inside Red Hat or Red Hat-based Linux Distributions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hyphen in "Hat-based" should technically be an en dash ("Hat–based"), as it applies to both words in the proper noun, but we can't hyphenate the proper noun. Also, please lowercase "distributions."


The RPM Package Manager (RPM) installation provides everything you need to run OpenSearch inside Red Hat or Red Hat-based Linux Distributions.

RPM supports CentOS 7 and 8, and Amazon Linux 2. If you have your own Java installation and set `JAVA_HOME` in your terminal application, macOS works, as well.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the comma following "8" and the comma following "works".


RPM supports CentOS 7 and 8, and Amazon Linux 2. If you have your own Java installation and set `JAVA_HOME` in your terminal application, macOS works, as well.

There are two methods for installing OpenSearch on RPM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the colon here should actually be a period, as the sentence does not directly introduce a list but rather introduces a heading. Or it might even be better to provide the two methods after the colon ("There are two methods for installing OpenSearch on RPM: manually or by using YUM.").

## Manual method


1. Download the RPM package directly from the [OpenSearch downloads page](https://opensearch.org/downloads.html){:target='\_blank'}. The RPM package can be download both as `x64` and `arm64`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the second instance of "download" to "downloaded".


1. Download the RPM package directly from the [OpenSearch downloads page](https://opensearch.org/downloads.html){:target='\_blank'}. The RPM package can be download both as `x64` and `arm64`.

2. Import the public GPG key. This key verifies that the your OpenSearch instance is signed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we define "GPG"? Please delete "the" in the second sentence (should just be "that your OpenSearch".


To verify that the repos appear in your repo list, use `sudo yum repolist`.

2. Clean your YUM cache, to ensure a smooth installation:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the comma following "cache".

sudo yum clean all
```

3. With the repository file downloaded, list all available versions of OpenSearch:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing "repository" to "repo," as you switched to this usage in the last instance.


Unless otherwise indicated, the highest minor version of OpenSearch installs.

To install a specific version of OpenSearch:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a complete sentence?


## Run OpenSearch

1. Run OpenSearch and OpenSearch Dashboards using `systemctl`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this step should end in a colon rather than a period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Documentation for upcoming RPM distribution release
5 participants