Add new Performance Analyzer metrics and fix table formatting #5182

hdhalter · 2023-10-10T23:20:40Z

Description

The table had some formatting issues, so I fixed the table formatting and added the new metrics. This takes the place of: #5114

Issues Resolved

n/a
opensearch-project/performance-analyzer#483

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Heather Halter <hdhalter@amazon.com>

hdhalter · 2023-10-10T23:22:51Z

@khushbr @ruai0511

Signed-off-by: Heather Halter <hdhalter@amazon.com>

ruai0511 · 2023-10-10T23:40:54Z

Thank you for re-formatting! This makes sense. I added two rows to the Dimension Reference table in the old pull request which aren't present here.

hdhalter · 2023-10-11T00:03:20Z

Thanks, @ruai0511 ! I added the two items in the Dimensions section. I'm still working out some of the kinks in the formatting, and should have another version up soon. If you have any information about the relationship between the metrics and dimensions, that would be helpful. I tried to provide some context in the opening paragraph, but not sure if I got it right. Thanks, again.

Signed-off-by: Heather Halter <hdhalter@amazon.com>

hdhalter · 2023-10-11T03:23:30Z

I have a few questions for dev/PM/ @ruai0511 :

Can you please explain the relationship between the metrics and dimensions? I would like to provide some context as the intro to the topic and as the intro to the dimensions table at the bottom.
What is WIP? Can we replace it with something meaningful?
Why is one of the tables "Dimensions: N/A"? What does that mean?
Thanks!

Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

_monitoring-your-cluster/pa/reference.md

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Fixed the intro statement Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

natebower

@hdhalter Please see my comments and changes and let me know if you have any questions. It looks like there are still placeholders/unfinished elements in places, I suspect that some terms should be in code font that are not currently, and I think that some of the phrasing may be inaccurate, so please get a doc review before approval. Thanks!

_monitoring-your-cluster/pa/reference.md

Editorial corrections. Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

_monitoring-your-cluster/pa/reference.md

Added a description under the Dimensions: N/A section and a couple editorial nits. Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

_monitoring-your-cluster/pa/reference.md

Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

natebower

LGTM

Removed search backpressure info, as requested; removed info marked with TBD. Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

hdhalter · 2023-10-13T20:53:30Z

I removed all the new content. @khushbr , please approve. Thanks!

hdhalter · 2023-10-13T20:58:04Z

@hdhalter I made another commit based on the reviews on my pull request (I don't think I can commit to your PR since I don't have write permission.)

I saw that, but @khushbr said the search backpressure metrics were not going in 2.11 now. I will make sure your input is reflected in the content when it gets delivered.

ruai0511 · 2023-10-13T20:58:47Z

@hdhalter I made another commit based on the reviews on my pull request (I don't think I can commit to your PR since I don't have write permission.)

I saw that, but @khushbr said the search backpressure metrics were not going in 2.11 now. I will make sure your input is reflected in the content when it gets delivered.

Ah Sure. Thanks!

hdhalter · 2023-10-13T22:12:06Z

Merging this without search backpressure metrics (which is targeting 2.12), since it fixes the formatting problems and has been edited. I've remove the 2.11 label.

* fixed problem with table and added new metrics Signed-off-by: Heather Halter <hdhalter@amazon.com> * fix formatting Signed-off-by: Heather Halter <hdhalter@amazon.com> * fixed table formatting Signed-off-by: Heather Halter <hdhalter@amazon.com> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Fixed the intro statement Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Apply suggestions from code review Editorial corrections. Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Added a description under the Dimensions: N/A section and a couple editorial nits. Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Removed search backpressure info, as requested; removed info marked with TBD. Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> --------- Signed-off-by: Heather Halter <hdhalter@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

…arch-project#5182) * fixed problem with table and added new metrics Signed-off-by: Heather Halter <hdhalter@amazon.com> * fix formatting Signed-off-by: Heather Halter <hdhalter@amazon.com> * fixed table formatting Signed-off-by: Heather Halter <hdhalter@amazon.com> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Fixed the intro statement Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Apply suggestions from code review Editorial corrections. Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Added a description under the Dimensions: N/A section and a couple editorial nits. Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Removed search backpressure info, as requested; removed info marked with TBD. Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> --------- Signed-off-by: Heather Halter <hdhalter@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>

* fixed problem with table and added new metrics Signed-off-by: Heather Halter <hdhalter@amazon.com> * fix formatting Signed-off-by: Heather Halter <hdhalter@amazon.com> * fixed table formatting Signed-off-by: Heather Halter <hdhalter@amazon.com> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Fixed the intro statement Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Apply suggestions from code review Editorial corrections. Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Added a description under the Dimensions: N/A section and a couple editorial nits. Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _monitoring-your-cluster/pa/reference.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update reference.md Removed search backpressure info, as requested; removed info marked with TBD. Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> --------- Signed-off-by: Heather Halter <hdhalter@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>

fixed problem with table and added new metrics

e923af8

Signed-off-by: Heather Halter <hdhalter@amazon.com>

hdhalter requested review from kolchfa-aws, Naarcha-AWS, vagimeli, ananzh, seanneumann, AMoo-Miki and natebower as code owners October 10, 2023 23:20

hdhalter mentioned this pull request Oct 10, 2023

Add Search Back Pressure PA metrics #5114

Closed

1 task

hdhalter added 3 - Tech review PR: Tech review in progress v2.11.0 labels Oct 10, 2023

hdhalter self-assigned this Oct 10, 2023

fix formatting

b6bac9a

Signed-off-by: Heather Halter <hdhalter@amazon.com>

hdhalter marked this pull request as draft October 11, 2023 00:51

fixed table formatting

d64d863

Signed-off-by: Heather Halter <hdhalter@amazon.com>

hdhalter marked this pull request as ready for review October 11, 2023 03:19

hdhalter added 3 commits October 11, 2023 18:17

Update reference.md

97ada2b

Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update reference.md

f92f980

Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update reference.md

16a8d92

Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Naarcha-AWS reviewed Oct 12, 2023

View reviewed changes

_monitoring-your-cluster/pa/reference.md Outdated Show resolved Hide resolved

Naarcha-AWS reviewed Oct 12, 2023

View reviewed changes

_monitoring-your-cluster/pa/reference.md Outdated Show resolved Hide resolved

Naarcha-AWS reviewed Oct 12, 2023

View reviewed changes

hdhalter and others added 4 commits October 12, 2023 13:22

Update _monitoring-your-cluster/pa/reference.md

fa549ec

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update _monitoring-your-cluster/pa/reference.md

11fa25d

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update _monitoring-your-cluster/pa/reference.md

e30538c

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update _monitoring-your-cluster/pa/reference.md

07ba666

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

hdhalter and others added 3 commits October 12, 2023 13:23

Update _monitoring-your-cluster/pa/reference.md

ad7986f

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update _monitoring-your-cluster/pa/reference.md

4de83fc

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update reference.md

9baa4d3

Fixed the intro statement Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

hdhalter added 5 - Editorial review PR: Editorial review in progress and removed 3 - Tech review PR: Tech review in progress labels Oct 12, 2023

natebower requested changes Oct 13, 2023

View reviewed changes

Apply suggestions from code review

25385f5

Editorial corrections. Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

khushbr reviewed Oct 13, 2023

View reviewed changes

_monitoring-your-cluster/pa/reference.md Outdated Show resolved Hide resolved

hdhalter added 5 commits October 13, 2023 11:14

Update reference.md

a621d53

Added a description under the Dimensions: N/A section and a couple editorial nits. Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update reference.md

1590445

Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update reference.md

42ea1e9

Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update reference.md

8287d25

Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

Update reference.md

c2bd088

Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

natebower reviewed Oct 13, 2023

View reviewed changes

_monitoring-your-cluster/pa/reference.md Outdated Show resolved Hide resolved

Update _monitoring-your-cluster/pa/reference.md

8f8537c

Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

natebower approved these changes Oct 13, 2023

View reviewed changes

Update reference.md

74c2031

Removed search backpressure info, as requested; removed info marked with TBD. Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>

khushbr approved these changes Oct 13, 2023

View reviewed changes

hdhalter removed 5 - Editorial review PR: Editorial review in progress v2.11.0 labels Oct 13, 2023

hdhalter merged commit 5769c16 into main Oct 13, 2023
4 checks passed

hdhalter deleted the pa-metrics-211 branch March 28, 2024 21:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new Performance Analyzer metrics and fix table formatting #5182

Add new Performance Analyzer metrics and fix table formatting #5182

hdhalter commented Oct 10, 2023

hdhalter commented Oct 10, 2023

ruai0511 commented Oct 10, 2023

hdhalter commented Oct 11, 2023

hdhalter commented Oct 11, 2023 •

edited

Loading

natebower left a comment

natebower left a comment

hdhalter commented Oct 13, 2023

hdhalter commented Oct 13, 2023

ruai0511 commented Oct 13, 2023

hdhalter commented Oct 13, 2023

Add new Performance Analyzer metrics and fix table formatting #5182

Add new Performance Analyzer metrics and fix table formatting #5182

Conversation

hdhalter commented Oct 10, 2023

Description

Issues Resolved

Checklist

hdhalter commented Oct 10, 2023

ruai0511 commented Oct 10, 2023

hdhalter commented Oct 11, 2023

hdhalter commented Oct 11, 2023 • edited Loading

natebower left a comment

Choose a reason for hiding this comment

natebower left a comment

Choose a reason for hiding this comment

hdhalter commented Oct 13, 2023

hdhalter commented Oct 13, 2023

ruai0511 commented Oct 13, 2023

hdhalter commented Oct 13, 2023

hdhalter commented Oct 11, 2023 •

edited

Loading