Remove references to _shard_doc #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opensearch does not currently appear to support `_shard_doc` as part of Point In Time search, so remove references to it from the documentation. Further details: - I don't see any reference to `_shard_doc` in the code on [Opensearch's](https://github.com/opensearch-project/OpenSearch) main branch at time of proposing the change. - ElasticSearch added `_shard_doc` in [7.12](elastic/elasticsearch-net#5337) and it looks like it was not added as part of Opensearch's [Point In Time work](opensearch-project/OpenSearch#1147). Signed-off-by: Bryce Seager van Dyk <bryce@vandyk.net.nz>
|
Verified in code, merging now. |
Naarcha-AWS
approved these changes
May 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 18, 2023
Opensearch does not currently appear to support `_shard_doc` as part of Point In Time search, so remove references to it from the documentation. Further details: - I don't see any reference to `_shard_doc` in the code on [Opensearch's](https://github.com/opensearch-project/OpenSearch) main branch at time of proposing the change. - ElasticSearch added `_shard_doc` in [7.12](elastic/elasticsearch-net#5337) and it looks like it was not added as part of Opensearch's [Point In Time work](opensearch-project/OpenSearch#1147). Signed-off-by: Bryce Seager van Dyk <bryce@vandyk.net.nz> (cherry picked from commit 3470787) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS
pushed a commit
that referenced
this pull request
May 18, 2023
Opensearch does not currently appear to support `_shard_doc` as part of Point In Time search, so remove references to it from the documentation. Further details: - I don't see any reference to `_shard_doc` in the code on [Opensearch's](https://github.com/opensearch-project/OpenSearch) main branch at time of proposing the change. - ElasticSearch added `_shard_doc` in [7.12](elastic/elasticsearch-net#5337) and it looks like it was not added as part of Opensearch's [Point In Time work](opensearch-project/OpenSearch#1147). (cherry picked from commit 3470787) Signed-off-by: Bryce Seager van Dyk <bryce@vandyk.net.nz> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli
pushed a commit
that referenced
this pull request
May 26, 2023
Opensearch does not currently appear to support `_shard_doc` as part of Point In Time search, so remove references to it from the documentation. Further details: - I don't see any reference to `_shard_doc` in the code on [Opensearch's](https://github.com/opensearch-project/OpenSearch) main branch at time of proposing the change. - ElasticSearch added `_shard_doc` in [7.12](elastic/elasticsearch-net#5337) and it looks like it was not added as part of Opensearch's [Point In Time work](opensearch-project/OpenSearch#1147). Signed-off-by: Bryce Seager van Dyk <bryce@vandyk.net.nz>
harshavamsi
pushed a commit
to harshavamsi/documentation-website
that referenced
this pull request
Oct 31, 2023
Opensearch does not currently appear to support `_shard_doc` as part of Point In Time search, so remove references to it from the documentation. Further details: - I don't see any reference to `_shard_doc` in the code on [Opensearch's](https://github.com/opensearch-project/OpenSearch) main branch at time of proposing the change. - ElasticSearch added `_shard_doc` in [7.12](elastic/elasticsearch-net#5337) and it looks like it was not added as part of Opensearch's [Point In Time work](opensearch-project/OpenSearch#1147). Signed-off-by: Bryce Seager van Dyk <bryce@vandyk.net.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opensearch does not currently appear to support
_shard_docas part of Point In Time search, so remove references to it from the documentation.Further details:
_shard_docin the code on Opensearch's main branch at time of proposing the change._shard_docin 7.12 and it looks like it was not added as part of Opensearch's Point In Time work.Issues Resolved
There do not appear to be any issues open related to this.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.