Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tagging on failure for KeyValue processor #3368

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

oeyh
Copy link
Collaborator

@oeyh oeyh commented Sep 20, 2023

Description

Tag the event with specified tags when key value processor runs into exception while processing the event.

Moved commits from #3255 by @shenkw1 and made a few tweaks.

Issues Resolved

Resolves #886

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

chenqi0805
chenqi0805 previously approved these changes Sep 21, 2023
shenkw1 and others added 4 commits September 22, 2023 12:01
Signed-off-by: Kat Shen <katshen@amazon.com>
Signed-off-by: Kat Shen <katshen@amazon.com>
Signed-off-by: Kat Shen <katshen@amazon.com>
Signed-off-by: Hai Yan <oeyh@amazon.com>
@oeyh
Copy link
Collaborator Author

oeyh commented Sep 22, 2023

Rebased and resolved merge conflicts.

@oeyh oeyh merged commit f2593a9 into opensearch-project:main Sep 25, 2023
23 of 24 checks passed
asifsmohammed pushed a commit to asifsmohammed/data-prepper that referenced this pull request Sep 27, 2023
* readme, config done, main code integration in progress

Signed-off-by: Kat Shen <katshen@amazon.com>

* clarify readme with example output

Signed-off-by: Kat Shen <katshen@amazon.com>

* add import statement

Signed-off-by: Kat Shen <katshen@amazon.com>

* Add tagging on failure

Signed-off-by: Hai Yan <oeyh@amazon.com>

---------

Signed-off-by: Kat Shen <katshen@amazon.com>
Signed-off-by: Hai Yan <oeyh@amazon.com>
Co-authored-by: Kat Shen <katshen@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential KeyValueProcessor feature: tag_on_failure
4 participants