-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the S3 sink to use the AWS Plugin for loading AWS credentials #2787
Updates the S3 sink to use the AWS Plugin for loading AWS credentials #2787
Conversation
…Resolves opensearch-project#2767 Signed-off-by: David Venable <dlv@amazon.com>
…meterize the regions to ensure they are not variable. Signed-off-by: David Venable <dlv@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #2787 +/- ##
============================================
- Coverage 94.12% 93.94% -0.18%
+ Complexity 2441 2437 -4
============================================
Files 278 278
Lines 6744 6759 +15
Branches 551 551
============================================
+ Hits 6348 6350 +2
- Misses 256 269 +13
Partials 140 140 |
public String getAwsStsRoleArn() { | ||
return awsStsRoleArn; | ||
} | ||
|
||
return awsCredentialsProvider; | ||
public Map<String, String> getAwsStsHeaderOverrides() { | ||
return awsStsHeaderOverrides; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no unit tests in AwsAuthenticationOptionsTest.java
file for these new methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmanning09 , I just pushed a change which adds testing for these getters.
…approach to deserialize using Jackson to better simulate the final usage. Signed-off-by: David Venable <dlv@amazon.com>
Description
Updates the
s3
sink to use the AWS Plugin. This now provides the AWS credentials for this sink. This includes some related refactoring including fixing a bug where the S3 client was created anew for every object write.Issues Resolved
Resolves #2767
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.