FIX: traceState not required in Link (#2363)

Signed-off-by: George Chen <qchea@amazon.com>
opensearch-project · Mar 3, 2023 · 6d4eb42 · 6d4eb42
1 parent 567e3bf
commit 6d4eb42
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 18 deletions.
diff --git a/data-prepper-api/src/main/java/org/opensearch/dataprepper/model/trace/DefaultLink.java b/data-prepper-api/src/main/java/org/opensearch/dataprepper/model/trace/DefaultLink.java
@@ -37,8 +37,6 @@ private DefaultLink(final Builder builder) {
         checkArgument(!builder.spanId.isEmpty(), "spanId cannot be an empty String");
         this.spanId = builder.spanId;
 
-        checkNotNull(builder.traceState, "traceState cannot be null");
-        checkArgument(!builder.traceState.isEmpty(), "traceState cannot be an empty String");
         this.traceState = builder.traceState;
 
         this.attributes = builder.attributes == null ? new HashMap<>() : builder.attributes;

diff --git a/data-prepper-api/src/test/java/org/opensearch/dataprepper/model/trace/DefaultLinkTest.java b/data-prepper-api/src/test/java/org/opensearch/dataprepper/model/trace/DefaultLinkTest.java
@@ -169,14 +169,6 @@ public void testBuilder_withMissingTraceId_throwsNullPointerException() {
         assertThrows(NullPointerException.class, builder::build);
     }
 
-    @Test
-    public void testBuilder_withMissingTraceState_throwsNullPointerException() {
-
-        builder.withTraceState(null);
-
-        assertThrows(NullPointerException.class, builder::build);
-    }
-
     @Test
     public void testBuilder_withEmptySpanId_throwsIllegalArgumentException() {
 
@@ -193,14 +185,6 @@ public void testBuilder_withEmptyTraceId_throwsIllegalArgumentException() {
         assertThrows(IllegalArgumentException.class, builder::build);
     }
 
-    @Test
-    public void testBuilder_withEmptyTraceState_throwsIllegalArgumentException() {
-
-        builder.withTraceState("");
-
-        assertThrows(IllegalArgumentException.class, builder::build);
-    }
-
     @Test
     public void testBuilder_withMissingAttributes_setsAttributesToEmptySet() {